diff options
| author | JF Bastien <jfbastien@apple.com> | 2019-06-26 19:50:12 +0000 |
|---|---|---|
| committer | JF Bastien <jfbastien@apple.com> | 2019-06-26 19:50:12 +0000 |
| commit | 0e828958264734e60115ba2482437008c822d7db (patch) | |
| tree | 3fc2aa5876f36d46ae328df9b7a5ee7dfa781894 /clang-tools-extra/clang-doc/BitcodeWriter.cpp | |
| parent | afa58b6ba19a54e6fd41ab3994e114f0f6bcb239 (diff) | |
BitStream reader: propagate errors
The bitstream reader handles errors poorly. This has two effects:
* Bugs in file handling (especially modules) manifest as an "unexpected end of
file" crash
* Users of clang as a library end up aborting because the code unconditionally
calls `report_fatal_error`
The bitstream reader should be more resilient and return Expected / Error as
soon as an error is encountered, not way late like it does now. This patch
starts doing so and adopting the error handling where I think it makes sense.
There's plenty more to do: this patch propagates errors to be minimally useful,
and follow-ups will propagate them further and improve diagnostics.
https://bugs.llvm.org/show_bug.cgi?id=42311
<rdar://problem/33159405>
Differential Revision: https://reviews.llvm.org/D63518
llvm-svn: 364464
Diffstat (limited to 'clang-tools-extra/clang-doc/BitcodeWriter.cpp')
| -rw-r--r-- | clang-tools-extra/clang-doc/BitcodeWriter.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-doc/BitcodeWriter.cpp b/clang-tools-extra/clang-doc/BitcodeWriter.cpp index ed235e09947e..46ae5af99f8a 100644 --- a/clang-tools-extra/clang-doc/BitcodeWriter.cpp +++ b/clang-tools-extra/clang-doc/BitcodeWriter.cpp @@ -214,7 +214,7 @@ static const std::vector<std::pair<BlockId, std::vector<RecordId>>> // AbbreviationMap -constexpr char BitCodeConstants::Signature[]; +constexpr unsigned char BitCodeConstants::Signature[]; void ClangDocBitcodeWriter::AbbreviationMap::add(RecordId RID, unsigned AbbrevID) { |