diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-10-13 09:57:44 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-10-13 15:39:47 +0200 |
| commit | deec9905c2390617769caeb0858792e616627bc0 (patch) | |
| tree | 196596494e43855e1d51b229f117ced050275ef2 | |
| parent | e842ae10c2111ad5b3d8adb9c61b7521bad6f823 (diff) | |
snippets_translate: Remove qAsConst(), std::as_const() from for loops
Pick-to: 6.2
Change-Id: If31883998a08073ecf4ca7bfb91ee000cc2f630f
Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
Reviewed-by: Christian Tismer <tismer@stackless.com>
| -rw-r--r-- | tools/snippets_translate/handlers.py | 5 | ||||
| -rw-r--r-- | tools/snippets_translate/tests/test_converter.py | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/tools/snippets_translate/handlers.py b/tools/snippets_translate/handlers.py index 57b00e9da..1af97ff64 100644 --- a/tools/snippets_translate/handlers.py +++ b/tools/snippets_translate/handlers.py @@ -231,7 +231,10 @@ def handle_for(x): elif x.count(":") > 0: iterator, iterable = content.split(":", 1) var = iterator.split()[-1].replace("&", "").strip() - new_x = f"for {remove_ref(var)} in {iterable.strip()}:" + iterable = iterable.strip() + if iterable.startswith("qAsConst(") or iterable.startswith("std::as_const("): + iterable = iterable[iterable.find("(") + 1: -1] + new_x = f"for {remove_ref(var)} in {iterable}:" return f"{get_indent(x)}{dstrip(new_x)}" diff --git a/tools/snippets_translate/tests/test_converter.py b/tools/snippets_translate/tests/test_converter.py index a1f9fe834..4cf614d1e 100644 --- a/tools/snippets_translate/tests/test_converter.py +++ b/tools/snippets_translate/tests/test_converter.py @@ -200,7 +200,7 @@ def test_for(): assert st("for (QChar ch : s)") == "for ch in s:" assert ( st("for (const QByteArray &ext : " "qAsConst(extensionList))") - == "for ext in qAsConst(extensionList):" + == "for ext in extensionList:" ) assert st("for (QTreeWidgetItem *item : found) {") == "for item in found:" |