aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Tismer <tismer@stackless.com>2024-09-20 13:25:58 +0200
committerChristian Tismer <tismer@stackless.com>2024-09-26 16:40:02 +0200
commitfacad37a8a62d84865b88e3bd4e38eb9a3e0419b (patch)
tree03f0ea2a18e609173ebce5fa10b3f7d6a7901bbd
parent97a32254cb5c323e6dd1f41c007aa0a43dd4a0d9 (diff)
type hints: Fix a bug introduced by PlaceHolderType
PlaceHolderType is used in QtCore, only. But it is unconditionally inserted into every module without importing which creates errors. Task-number: PYSIDE-2846 Change-Id: I86c6bdf04a089ff755399945b3fa3dee8a6e0bbe Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
-rw-r--r--sources/shiboken6/shibokenmodule/files.dir/shibokensupport/signature/lib/pyi_generator.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/sources/shiboken6/shibokenmodule/files.dir/shibokensupport/signature/lib/pyi_generator.py b/sources/shiboken6/shibokenmodule/files.dir/shibokensupport/signature/lib/pyi_generator.py
index 91af2da31..8d6879eb3 100644
--- a/sources/shiboken6/shibokenmodule/files.dir/shibokensupport/signature/lib/pyi_generator.py
+++ b/sources/shiboken6/shibokenmodule/files.dir/shibokensupport/signature/lib/pyi_generator.py
@@ -335,9 +335,10 @@ def generate_pyi(import_name, outpath, options):
wr.print()
wr.print("NoneType: typing.TypeAlias = type[None]")
# We use it only in QtCore at the moment, but this
- # could be extended to other modules.
- wr.print("PlaceHolderType = typing.TypeVar(\"PlaceHolderType\", "
- "bound=PySide6.QtCore.QObject)")
+ # could be extended to other modules. (must import QObject then)
+ if import_name == "PySide6.QtCore":
+ wr.print("PlaceHolderType = typing.TypeVar(\"PlaceHolderType\", "
+ "bound=PySide6.QtCore.QObject)")
wr.print()
else:
wr.print(line)