aboutsummaryrefslogtreecommitdiffstats
path: root/sources/pyside6/libpyside/pysideproperty.cpp
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2022-03-02 15:00:19 +0100
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2022-03-03 11:39:33 +0100
commit0e84a0e334e2a5ea5c46d21ba4295a97d8448c58 (patch)
tree77524a8b81ad350fa40bc555d1db715bfe81dfaf /sources/pyside6/libpyside/pysideproperty.cpp
parent0a9c75485ddab77bc1d01d731d5559cec3539d5c (diff)
Add explanatory comment to PySideProperty
Amends d3883e9186892e673e8a66ad6651409d5eaf7cf3. Pick-to: 6.2 Task-number: PYSIDE-1402 Task-number: PYSIDE-1836 Change-Id: I8bbdb2a4f4d82786d15db85b3b8e364b9df35d8a Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/pysideproperty.cpp')
-rw-r--r--sources/pyside6/libpyside/pysideproperty.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/sources/pyside6/libpyside/pysideproperty.cpp b/sources/pyside6/libpyside/pysideproperty.cpp
index 720050335..6525af32c 100644
--- a/sources/pyside6/libpyside/pysideproperty.cpp
+++ b/sources/pyside6/libpyside/pysideproperty.cpp
@@ -272,6 +272,9 @@ static void qpropertyDeAlloc(PyObject *self)
Py_TYPE(self)->tp_free(self);
}
+// Create a copy of the property to prevent the @property.setter from modifying
+// the property in place and avoid strange side effects in derived classes
+// (cf https://bugs.python.org/issue1620).
static PyObject *
_property_copy(PyObject *old, PyObject *get, PyObject *set, PyObject *reset, PyObject *del)
{