diff options
| author | Christian Tismer <tismer@stackless.com> | 2021-07-05 15:58:39 +0200 |
|---|---|---|
| committer | Christian Tismer <tismer@stackless.com> | 2021-07-07 06:58:07 +0000 |
| commit | 2cce79b0267570642c719598388db9960b0fe953 (patch) | |
| tree | a7a6d2232200ad4c68a3d5b4f506471ce470f5bb /sources/pyside6/libpyside/pysideqflags.cpp | |
| parent | fec1611e9f42c1f0a13eb33474df2ed8ee480842 (diff) | |
shiboken: clean-up after replacing the type extension macros by functions
[ChangeLog][PySide6] During replacement of type extender macros by
functions, a hidden enum/flags alias error was detected and fixed.
After macros were replaced by functions, redundant extension-fields
could be removed. This was possible in steps, removing
`converterPtr` from PySideQFlagsTypePrivate and SbkEnumTypePrivate,
individually.
That means the structures are really distinct, now and no structural
overlapping is left.
The enum/flag alias bug is reported here, as a follow-up to the
"replace the type extension macros by functions" change.
The involved `setTypeConverter` function interface was fixed and the
unused `getTypeConverter` function was removed.
Change-Id: Ieee111465ab5fc2f5ae23f9e488b12883a509bcd
Task-number: PYSIDE-535
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/pysideqflags.cpp')
| -rw-r--r-- | sources/pyside6/libpyside/pysideqflags.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/sources/pyside6/libpyside/pysideqflags.cpp b/sources/pyside6/libpyside/pysideqflags.cpp index d9b8c009e..b0ca39aa0 100644 --- a/sources/pyside6/libpyside/pysideqflags.cpp +++ b/sources/pyside6/libpyside/pysideqflags.cpp @@ -47,7 +47,6 @@ extern "C" { struct PySideQFlagsTypePrivate { - SbkConverter **converterPtr; SbkConverter *converter; }; /** @@ -187,10 +186,6 @@ namespace QFlags PyTypeObject *type = (PyTypeObject *)SbkType_FromSpec(&newspec); Py_TYPE(type) = &PyType_Type; - PySideQFlagsType *flagsType = reinterpret_cast<PySideQFlagsType *>(type); - auto *pftp = PepType_PFTP(flagsType); - pftp->converterPtr = &pftp->converter; - if (PyType_Ready(type) < 0) return nullptr; |