diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2021-03-11 10:42:36 +0100 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2021-03-11 15:19:42 +0100 |
| commit | 146b3cb79c3f0927df3d7c5d9fdc9c67b976051d (patch) | |
| tree | c2debab92f118f1da0fd4af05a3e72dc254c938a /sources/pyside6/libpyside/pysideslot.cpp | |
| parent | 7d602dc46163be603e87b1ef4f8db7b1ab87c1f6 (diff) | |
libpyside: Fix some clang analzyer warnings
- Use nullptr
- Initialize variables
- Remove else after return
- Remove C-style casts
- Avoid constructing QString from const char *
- Use emit for signals
Change-Id: I6ba8cad51f4b2a22f94996d1a9d8c3ae87c35099
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/pyside6/libpyside/pysideslot.cpp')
| -rw-r--r-- | sources/pyside6/libpyside/pysideslot.cpp | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/sources/pyside6/libpyside/pysideslot.cpp b/sources/pyside6/libpyside/pysideslot.cpp index 81f93c555..cd81a9a39 100644 --- a/sources/pyside6/libpyside/pysideslot.cpp +++ b/sources/pyside6/libpyside/pysideslot.cpp @@ -70,11 +70,11 @@ static PyObject *slotCall(PyObject *, PyObject *, PyObject *); // Class Definition ----------------------------------------------- static PyType_Slot PySideSlotType_slots[] = { - {Py_tp_call, (void *)slotCall}, - {Py_tp_init, (void *)slotTpInit}, - {Py_tp_new, (void *)PyType_GenericNew}, - {Py_tp_dealloc, (void *)Sbk_object_dealloc}, - {0, 0} + {Py_tp_call, reinterpret_cast<void *>(slotCall)}, + {Py_tp_init, reinterpret_cast<void *>(slotTpInit)}, + {Py_tp_new, reinterpret_cast<void *>(PyType_GenericNew)}, + {Py_tp_dealloc, reinterpret_cast<void *>(Sbk_object_dealloc)}, + {0, nullptr} }; static PyType_Spec PySideSlotType_spec = { "2:PySide6.QtCore.Slot", @@ -85,7 +85,7 @@ static PyType_Spec PySideSlotType_spec = { }; -static PyTypeObject *PySideSlotTypeF(void) +static PyTypeObject *PySideSlotTypeF() { static PyTypeObject *type = reinterpret_cast<PyTypeObject *>( SbkType_FromSpec(&PySideSlotType_spec)); @@ -99,7 +99,7 @@ int slotTpInit(PyObject *self, PyObject *args, PyObject *kw) char *argName = nullptr; PyObject *argResult = nullptr; - if (emptyTuple == 0) + if (emptyTuple == nullptr) emptyTuple = PyTuple_New(0); if (!PyArg_ParseTupleAndKeywords(emptyTuple, kw, "|sO:QtCore.Slot", @@ -179,8 +179,7 @@ PyObject *slotCall(PyObject *self, PyObject *args, PyObject * /* kw */) } // extern "C" -namespace PySide { -namespace Slot { +namespace PySide::Slot { static const char *Slot_SignatureStrings[] = { "PySide6.QtCore.Slot(self,*types:type,name:str=nullptr,result:str=nullptr)->typing.Callable[...,typing.Optional[str]]", @@ -195,5 +194,4 @@ void init(PyObject *module) PyModule_AddObject(module, "Slot", reinterpret_cast<PyObject *>(PySideSlotTypeF())); } -} // namespace Slot -} // namespace PySide +} // namespace PySide::Slot |