diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-10-06 16:08:16 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-10-17 19:08:18 +0200 |
| commit | a51fc3b524d075bc84c1f746e8bbf6016c07790b (patch) | |
| tree | 2bf45b5a1591c65d312681023a39ad0d1fda58e0 /sources/pyside6/plugins/uitools/customwidget.cpp | |
| parent | 9e2ac0478db3ed4e33119f2128a9053a852f2fac (diff) | |
UiTools/Designer plugins: Fix some static code analysis warnings
Fix warnings about implicit cast to bool (pointer/int).
Fix some auto * definitions of pointers.
As a drive-by, modernize string constants.
Pick-to: 6.6 6.5
Change-Id: I05f83de9299dd91e80fc4252514f6cbbebcf1cfc
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/pyside6/plugins/uitools/customwidget.cpp')
| -rw-r--r-- | sources/pyside6/plugins/uitools/customwidget.cpp | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/sources/pyside6/plugins/uitools/customwidget.cpp b/sources/pyside6/plugins/uitools/customwidget.cpp index 4e0949b25..976754feb 100644 --- a/sources/pyside6/plugins/uitools/customwidget.cpp +++ b/sources/pyside6/plugins/uitools/customwidget.cpp @@ -24,22 +24,22 @@ bool PyCustomWidget::isInitialized() const QIcon PyCustomWidget::icon() const { - return QIcon(); + return {}; } QString PyCustomWidget::domXml() const { - return QString(); + return {}; } QString PyCustomWidget::group() const { - return QString(); + return {}; } QString PyCustomWidget::includeFile() const { - return QString(); + return {}; } QString PyCustomWidget::name() const @@ -49,12 +49,12 @@ QString PyCustomWidget::name() const QString PyCustomWidget::toolTip() const { - return QString(); + return {}; } QString PyCustomWidget::whatsThis() const { - return QString(); + return {}; } // A copy of this code exists in PyDesignerCustomWidget::createWidget() @@ -64,9 +64,9 @@ QWidget *PyCustomWidget::createWidget(QWidget *parent) // Create a python instance and return cpp object PyObject *pyParent = nullptr; bool unknownParent = false; - if (parent) { + if (parent != nullptr) { pyParent = reinterpret_cast<PyObject *>(Shiboken::BindingManager::instance().retrieveWrapper(parent)); - if (pyParent) { + if (pyParent != nullptr) { Py_INCREF(pyParent); } else { static Shiboken::Conversions::SpecificConverter converter("QWidget*"); @@ -79,11 +79,11 @@ QWidget *PyCustomWidget::createWidget(QWidget *parent) } Shiboken::AutoDecRef pyArgs(PyTuple_New(1)); - PyTuple_SET_ITEM(pyArgs, 0, pyParent); // tuple will keep pyParent reference + PyTuple_SET_ITEM(pyArgs.object(), 0, pyParent); // tuple will keep pyParent reference // Call python constructor - auto result = reinterpret_cast<SbkObject *>(PyObject_CallObject(m_pyObject, pyArgs)); - if (!result) { + auto *result = reinterpret_cast<SbkObject *>(PyObject_CallObject(m_pyObject, pyArgs)); + if (result == nullptr) { qWarning("Unable to create a Python custom widget of type \"%s\".", qPrintable(m_name)); PyErr_Print(); |