diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2021-03-11 10:42:36 +0100 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2021-03-11 15:19:42 +0100 |
| commit | 146b3cb79c3f0927df3d7c5d9fdc9c67b976051d (patch) | |
| tree | c2debab92f118f1da0fd4af05a3e72dc254c938a /sources/pyside6/tests/pysidetest/testobject.h | |
| parent | 7d602dc46163be603e87b1ef4f8db7b1ab87c1f6 (diff) | |
libpyside: Fix some clang analzyer warnings
- Use nullptr
- Initialize variables
- Remove else after return
- Remove C-style casts
- Avoid constructing QString from const char *
- Use emit for signals
Change-Id: I6ba8cad51f4b2a22f94996d1a9d8c3ae87c35099
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/pyside6/tests/pysidetest/testobject.h')
| -rw-r--r-- | sources/pyside6/tests/pysidetest/testobject.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/sources/pyside6/tests/pysidetest/testobject.h b/sources/pyside6/tests/pysidetest/testobject.h index c31a2ab73..2795cec5c 100644 --- a/sources/pyside6/tests/pysidetest/testobject.h +++ b/sources/pyside6/tests/pysidetest/testobject.h @@ -95,11 +95,11 @@ class PYSIDETEST_API TestObjectWithNamespace : public QObject Q_OBJECT public: TestObjectWithNamespace(QObject* parent) : QObject(parent) {} - QString name() { return "TestObjectWithNamespace"; } + QString name() { return QStringLiteral("TestObjectWithNamespace"); } - void callSignal(TestObjectWithNamespace* obj) { emitSignal(obj); } - void callSignalWithNamespace(TestObjectWithNamespace* obj) { emitSignalWithNamespace(obj); } - void callSignalWithTypedef(int val) { emitSignalWithTypedef(val); } + void callSignal(TestObjectWithNamespace* obj) { emit emitSignal(obj); } + void callSignalWithNamespace(TestObjectWithNamespace* obj) { emit emitSignalWithNamespace(obj); } + void callSignalWithTypedef(int val) { emit emitSignalWithTypedef(val); } signals: void emitSignal(TestObjectWithNamespace* obj); @@ -114,7 +114,7 @@ class PYSIDETEST_API TestObject2WithNamespace : public QObject Q_OBJECT public: TestObject2WithNamespace(QObject* parent) : QObject(parent) {} - QString name() { return "TestObject2WithNamespace"; } + QString name() { return QStringLiteral("TestObject2WithNamespace"); } }; PYSIDETEST_API QDebug operator<<(QDebug dbg, TestObject2WithNamespace& testObject); @@ -134,7 +134,7 @@ class PYSIDETEST_API TestObjectWithoutNamespace : public QObject public: enum Enum2 { Option3 = 3, Option4 = 4}; TestObjectWithoutNamespace(QObject* parent) : QObject(parent) {} - QString name() { return "TestObjectWithoutNamespace"; } + QString name() { return QStringLiteral("TestObjectWithoutNamespace"); } void callSignal(TestObjectWithoutNamespace* obj) { emitSignal(obj); } void callSignalWithNamespace(TestObjectWithoutNamespace* obj) { emitSignalWithNamespace(obj); } |