diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2024-04-19 07:40:17 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2024-04-19 11:11:36 +0200 |
| commit | a91c048fd8423f361ff50e926e24e1fe69884563 (patch) | |
| tree | 44a83eec4a3f0c2f446c8715c0b106bbbb7c2892 /sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp | |
| parent | 9159ba17edad1aa49b07418a7a6793f4526dca86 (diff) | |
shiboken: Prepare for [[nodiscard]] QFile::open
Check the return value.
Pick-to: 6.7
Change-Id: Iccbdbc033e25ee997c3d0904d8af0903c0dc319e
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp')
| -rw-r--r-- | sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp b/sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp index 1acfe1375..31a629a9e 100644 --- a/sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp +++ b/sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp @@ -3540,16 +3540,22 @@ static QList<std::shared_ptr<MetaClass> > if (!result.isValid() && graph.nodeCount()) { QTemporaryFile tempFile(QDir::tempPath() + u"/cyclic_depXXXXXX.dot"_s); tempFile.setAutoRemove(false); - tempFile.open(); - graph.dumpDot(tempFile.fileName(), - [] (const AbstractMetaClassCPtr &c) { return c->name(); }); + const bool ok = tempFile.open(); + if (ok) { + graph.dumpDot(tempFile.fileName(), + [] (const AbstractMetaClassCPtr &c) { return c->name(); }); + } QString message; QTextStream str(&message); str << "Cyclic dependency of classes found:"; for (const auto &c : result.cyclic) str << ' ' << c->name(); - str << ". Graph can be found at \"" << QDir::toNativeSeparators(tempFile.fileName()) << '"'; + str << '.'; + if (ok) { + str << " Graph can be found at \"" + << QDir::toNativeSeparators(tempFile.fileName()) << '"'; + } qCWarning(lcShiboken, "%s", qPrintable(message)); } |