diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-12-19 14:09:23 +0100 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-12-22 09:30:08 +0100 |
| commit | 1930ac417cc24ed74842e1a6f1c751ce2cfc47d0 (patch) | |
| tree | 78387dc7d565b1124a874c13074d929022be69aa /sources/shiboken6/tests/libsample/injectcode.cpp | |
| parent | 8cc5d64cf80f918b75366e148c7a951404b2313b (diff) | |
Fix coding style of the shiboken tests
- Place star/reference correctly
- Fix include order
- Streamline code, wrap long lines
- Use member initialization and default special methods
Change-Id: I7b7e7d8e8c9562cd932bee8144bc44d6b2dda0a5
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/shiboken6/tests/libsample/injectcode.cpp')
| -rw-r--r-- | sources/shiboken6/tests/libsample/injectcode.cpp | 31 |
1 files changed, 14 insertions, 17 deletions
diff --git a/sources/shiboken6/tests/libsample/injectcode.cpp b/sources/shiboken6/tests/libsample/injectcode.cpp index d83d53d1a..1c723c44f 100644 --- a/sources/shiboken6/tests/libsample/injectcode.cpp +++ b/sources/shiboken6/tests/libsample/injectcode.cpp @@ -2,18 +2,15 @@ // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 #include "injectcode.h" + #include <sstream> -InjectCode::InjectCode() -{ -} +InjectCode::InjectCode() = default; -InjectCode::~InjectCode() -{ -} +InjectCode::~InjectCode() = default; template<typename T> -const char* InjectCode::toStr(const T& value) +const char *InjectCode::toStr(const T &value) { std::ostringstream s; s << value; @@ -21,41 +18,41 @@ const char* InjectCode::toStr(const T& value) return m_valueHolder.c_str(); } -const char* InjectCode::simpleMethod1(int arg0, int arg1) +const char *InjectCode::simpleMethod1(int arg0, int arg1) { return toStr(arg0 + arg1); } -const char* InjectCode::simpleMethod2() +const char *InjectCode::simpleMethod2() { return "_"; } -const char* InjectCode::simpleMethod3(int argc, char** argv) +const char *InjectCode::simpleMethod3(int argc, char **argv) { for (int i = 0; i < argc; ++i) m_valueHolder += argv[i]; return m_valueHolder.c_str(); } -const char* InjectCode::overloadedMethod(int arg0, bool arg1) +const char *InjectCode::overloadedMethod(int arg0, bool arg1) { toStr(arg0); m_valueHolder += arg1 ? "true" : "false"; return m_valueHolder.c_str(); } -const char* InjectCode::overloadedMethod(int arg0, double arg1) +const char *InjectCode::overloadedMethod(int arg0, double arg1) { return toStr(arg0 + arg1); } -const char* InjectCode::overloadedMethod(int argc, char** argv) +const char *InjectCode::overloadedMethod(int argc, char **argv) { return simpleMethod3(argc, argv); } -const char* InjectCode::virtualMethod(int arg) +const char *InjectCode::virtualMethod(int arg) { return toStr(arg); } @@ -68,13 +65,13 @@ int InjectCode::arrayMethod(int count, int *values) const return ret; } -int InjectCode::sumArrayAndLength(int* values) const +int InjectCode::sumArrayAndLength(int *values) const { int sum = 0; - while(*values) { + while (*values) { sum = sum + *values + 1; - values++; + ++values; } return sum; |