diff options
| author | Christian Tismer <tismer@stackless.com> | 2021-10-26 17:38:46 +0200 |
|---|---|---|
| committer | Christian Tismer <tismer@stackless.com> | 2021-10-28 16:02:19 +0200 |
| commit | bee4cd31d60f3b35a37a2eb98fdfc60ba76cfe1c (patch) | |
| tree | 865360d7c052a6afe294d0e38252f0566a41420c /sources/shiboken6 | |
| parent | 9548ddd822b839ed0dfea27b26c74ad1c87746fd (diff) | |
__feature__: handle properties with function overloads
This is the implementation, see the conclusion of the issue.
[ChangeLog][PySide6] When a property would override an
existing function with multiple arity or parameters,
append an underscore to the property name.
REMARK: The current implementation is very correct. It uses
introspection via the signature module.
But that adds a constant overhead to the true_property
feature. Actually, there are only 2 known cases where this
overlap happens. It might be considered to simplify things
by checking the string names of these two functions?
Fixes: PYSIDE-1670
Pick-to: 6.2
Change-Id: I14927995698726957ba8c515dddf5e37c21910ce
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/shiboken6')
| -rw-r--r-- | sources/shiboken6/libshiboken/signature/signature_p.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sources/shiboken6/libshiboken/signature/signature_p.h b/sources/shiboken6/libshiboken/signature/signature_p.h index 7e622f3f1..029cd7cca 100644 --- a/sources/shiboken6/libshiboken/signature/signature_p.h +++ b/sources/shiboken6/libshiboken/signature/signature_p.h @@ -76,7 +76,7 @@ PyObject *GetSignature_Function(PyObject *, PyObject *); PyObject *GetSignature_TypeMod(PyObject *, PyObject *); PyObject *GetSignature_Wrapper(PyObject *, PyObject *); -PyObject *get_signature_intern(PyObject *ob, PyObject *modifier); +LIBSHIBOKEN_API PyObject *get_signature_intern(PyObject *ob, PyObject *modifier); PyObject *PySide_BuildSignatureProps(PyObject *class_mod); PyObject *GetClassOrModOf(PyObject *ob); |