diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-06-28 22:43:21 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-06-29 18:31:00 +0200 |
| commit | a6bebdb67e5a0d780242f3ff9f8ff5cf0f3da631 (patch) | |
| tree | d2171eae08c8ff1c265a1c4fcb47eef47adb3688 /tools/snippets_translate/main.py | |
| parent | 4d6f32a6a4033b5986e7d19185bbc6bfb941d218 (diff) | |
shiboken6: Refactor argument conversion for virtual method overrides
Virtual method overrides use Py_BuildValue() to create the argument
tuple for the call with its built-in conversions.
Fold the code for creating the argument and its format string
into a new helper CppGenerator::virtualMethodNativeArg().
Remove ShibokenGenerator::getFormatUnitString().
Change the logic to check for conversion rules from modifications and
convertable primitives first and fall back to shiboken conversions for
the rest, removing the complicated condition duplicated in
ShibokenGenerator::getFormatUnitString() and
CppGenerator::writeVirtualMethodNativeArgs().
This fixes a bug where no conversion was created when passing
smart pointer by values in a virtual functions.
Task-number: PYSIDE-454
Change-Id: I20ef047c89a0d0047f5234a90aae548ca8e6b932
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'tools/snippets_translate/main.py')
0 files changed, 0 insertions, 0 deletions