aboutsummaryrefslogtreecommitdiffstats
path: root/sources/pyside6
diff options
context:
space:
mode:
Diffstat (limited to 'sources/pyside6')
-rw-r--r--sources/pyside6/libpyside/qobjectconnect.cpp7
-rw-r--r--sources/pyside6/tests/QtCore/bug_1019.py1
2 files changed, 6 insertions, 2 deletions
diff --git a/sources/pyside6/libpyside/qobjectconnect.cpp b/sources/pyside6/libpyside/qobjectconnect.cpp
index 608eae170..72c80645f 100644
--- a/sources/pyside6/libpyside/qobjectconnect.cpp
+++ b/sources/pyside6/libpyside/qobjectconnect.cpp
@@ -63,7 +63,7 @@ QDebug operator<<(QDebug d, const GetReceiverResult &r)
d.noquote();
d.nospace();
d << "GetReceiverResult(receiver=" << r.receiver << ", self=" << r.self
- << ", sig=" << r.callbackSig << "slotIndex=" << r.slotIndex
+ << ", sig=\"" << r.callbackSig << "\", slotIndex=" << r.slotIndex
<< ", usingGlobalReceiver=" << r.usingGlobalReceiver << ')';
return d;
}
@@ -101,7 +101,10 @@ static GetReceiverResult getReceiver(QObject *source, const char *signal,
result.usingGlobalReceiver = !result.receiver || forceGlobalReceiver;
- // Check if this callback is a overwrite of a non-virtual Qt slot.
+ // Check if this callback is a overwrite of a non-virtual Qt slot (pre-Jira bug 1019).
+ // Make it possible to connect to a MyWidget.show() although QWidget.show()
+ // is a non-virtual slot which would be found by QMetaObject search.
+ // FIXME PYSIDE7: This is arguably a bit of a misguided "feature", remove?
if (!result.usingGlobalReceiver && result.receiver && result.self) {
result.callbackSig =
PySide::Signal::getCallbackSignature(signal, result.receiver, callback,
diff --git a/sources/pyside6/tests/QtCore/bug_1019.py b/sources/pyside6/tests/QtCore/bug_1019.py
index 89e400428..4a35956b1 100644
--- a/sources/pyside6/tests/QtCore/bug_1019.py
+++ b/sources/pyside6/tests/QtCore/bug_1019.py
@@ -30,6 +30,7 @@ class MyTimer2 (MyTimer):
pass
def start(self):
+ """ 'Overrides' non-virtual slot QTimer.start()."""
self.startCalled = True
QCoreApplication.instance().quit()