aboutsummaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
...
* create_changelog.py: Reduce bug-fix release commits appearing in minor ↵Friedemann Kleint2023-09-201-0/+4
| | | | | | | | | | version logs, take 2 Set the command line option from the release type auto-detection. Pick-to: 6.6 6.5 6.2 5.15 Change-Id: If911949c43cbababb083a63811a6ce2b491ec504 Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* Revert "create_changelog.py: Reduce bug-fix release commits appearing in ↵Friedemann Kleint2023-09-201-8/+3
| | | | | | | | | | | | | | | minor version logs" This reverts commit 7ec3ab49fb4cfe7bd062507b15c57644d7032726. The change was done in the wrong place, it only worked for [ChangeLog] entries. The script actually has an option for excluding Pick-to; it just needs to be set. Pick-to: 6.6 6.5 6.2 5.15 Change-Id: I6cc5e929d4f2f9402eb214c87ae40c049f968f3a Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* Android Deployment: auto download the required Android NDK and SDKShyamnath Premnadh2023-09-082-31/+311
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Enable automatic download of Android NDK and SDK for creating Android PySide6 and shiboken6 wheels. Earlier, the user was required to manually download it and supply as a command line argument. - They are downloaded into the HOME directory of the user into the folder .pyside6_android_deploy. This is also similar to buildozer which downloads them into .buildozer. - The downloaded NDK is set to r25c, same as buildozer. The latest Android SDK packages are downloaded. - For the deployment tool, incase the NDK and SDK path are not provided either through the command line or through the configuration .spec file, the it will look for the NDK and SDK inside .pyside6_android_deploy, before falling back to the default Android NDK and SDK that buildozer supplies. buildozer will download them. - As a addition, a small code rearranging is also done, along with changing the deprecated subprocess.call() to subprocess.run(). Task-number: PYSIDE-1612 Change-Id: Ie8d51f8c7634b5b320b1dce2d4164985cbfbaaca Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* create_changelog.py: Add more smartness to the optionsFriedemann Kleint2023-09-081-7/+38
| | | | | | | | | | | | | If a change log exists, log from its last commit to HEAD to get an update. Extract functions to get the revision range with LTS handling. Complements 31f393cc472849ed4556b923f0992203fa14a2a0. Pick-to: 6.5 6.2 5.15 Change-Id: I67e7e69fcbc2ce7e2fdb62a127fec97e0fb3186a Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* create_changelog.py: Add some smartness to the optionsFriedemann Kleint2023-09-051-6/+29
| | | | | | | | | On the community repo with the standard v{major}.{minor}.{patch} tag-naming convention, only option -r is required. Pick-to: 6.5 6.2 5.15 Change-Id: Ib69b45a07d1b9e3fabaa99e9a561f1769c192ba5 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* create_changelog.py: Reduce bug-fix release commits appearing in minor ↵Friedemann Kleint2023-09-051-3/+8
| | | | | | | | | | | version logs Remove commits with "Pick-to " for non-bugfix releases. Pick-to: 6.5 6.2 5.15 Change-Id: I1d6456b413e51578a7ac8020df64245a76848d63 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* Documentation: Exclude QtDataVisualizationFriedemann Kleint2023-08-231-0/+3
| | | | | | | | QtGraphs duplicates symbols from QtDataVisualization causing shiboken errors. Exclude the now deprecated QtDataVisualization. Change-Id: Iacdde84189ee87cf4ea058aa635272e187c30fce Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* example_gallery: Handle Qt example directoriesFriedemann Kleint2023-08-031-7/+42
| | | | | | | | | | | | | | | Add an option to be able to include examples found in the Qt / qtdoc repository. The build_rst_docs target also uses it if --qt-src-dir is given. It is then possible to include pure QML C++ examples from the qtdoc and other repositories. Task-number: PYSIDE-2206 Change-Id: I1b28d5ba5a134101a21fa936f87264a68bada71e Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* example_gallery: Introduce a data class for example dataFriedemann Kleint2023-08-031-22/+38
| | | | | | | | Pick-to: 6.5 Task-number: PYSIDE-2206 Change-Id: I64c9862696e9fcb281436aff417d41b96211435e Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* example_gallery: Introduce a data class for example parametersFriedemann Kleint2023-08-031-37/+71
| | | | | | | | Pick-to: 6.5 Task-number: PYSIDE-2206 Change-Id: I2c6157671e9618b77dd6d4f0c54d986ed819481a Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* example_gallery: Extract some subroutinesFriedemann Kleint2023-08-031-28/+45
| | | | | | | | Pick-to: 6.5 Task-number: PYSIDE-2206 Change-Id: I7d1c2ebe23cbbad54de4fdda5bd281217e32f2b7 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* Add the Qt Graphs widgetgallery exampleFriedemann Kleint2023-07-281-1/+1
| | | | | | | | | It is a copy of the QtDataVisualization graph gallery example adapted to Qt Graphs. Task-number: PYSIDE-2206 Change-Id: I908312b15324dd030f5610508f13299921fafc26 Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* Android Deployment: Enable unity buildShyamnath Premnadh2023-07-261-1/+1
| | | | | | | | - enables unity build for building Android wheels Task-number: PYSIDE-1612 Change-Id: Ie13632da64b331a6687874956debbb5db49f6e05 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* Android Deployment: Rpath changes through linker flagsShyamnath Premnadh2023-07-261-2/+10
| | | | | | | | | | | | | - Using patchelf to modify the binaries for rpath changes corrupts the binary. This leads to binaries not being able to be loaded at startup by the Android runtime which is required for establishing callbacks from C++ back to Python. - Using linker flags -Wl,-rpath='$ORIGIN' -Wl,-rpath='$ORIGIN/Qt/lib' and disabling patchelf for Android cross compilation solves the issue Task-number: PYSIDE-1612 Change-Id: I70e74d3ca2b0bc65e2565268c36038eeb7c47ddd Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* snippets_translate: Prevent the variable initialization code from triggering ↵Friedemann Kleint2023-07-052-4/+13
| | | | | | | | | | | | | | | | for functions The code trying to change a constructor initialization: "Foo foo(2);" into "foo = Foo(2)" also triggered for member function definitions returning pointers "Foo *Foo:foo()" and many function declarations in headers. Restrict this by checking for a semicolon and non-presence of some function qualifiers. Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: I224ac3e7321e57f1c5beecdcdb568a273330a664 Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* snippets_translate: Remove _L1, u string/character literalsFriedemann Kleint2023-06-281-1/+1
| | | | | | | | Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: I26ef6c9631c48c1bdde852e3bb3cd222ffec1260 Reviewed-by: Christian Tismer <tismer@stackless.com> Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
* example_gallery: Support markdownFriedemann Kleint2023-05-151-27/+64
| | | | | | | | Pick-to: 6.5 Initial-patch-by: Dennis Oberst <dennis.oberst@qt.io> Task-number: PYSIDE-1106 Change-Id: Ia8e1dbe33b859ef235db7612f36f2c225ff89902 Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* example_gallery: Use headline in galleryFriedemann Kleint2023-05-121-1/+21
| | | | | | | | | | Retrieve headline and use it instead of the standard "found in dir" text where possible. Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: I869e28f14fe1d6b7f477a1e01284f3fff45f4eae Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* example_gallery: Remove existing target directoryFriedemann Kleint2023-05-121-3/+7
| | | | | | | | Pick-to: 6.5 Initial-patch-by: Dennis Oberst <dennis.oberst@qt.io> Task-number: PYSIDE-1106 Change-Id: I76466254b455ac07f8b537e2e758d6720885c128 Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* example_gallery: Ensure tutorials are grouped togetherFriedemann Kleint2023-05-041-0/+11
| | | | | | | | | | | | Sort the example lists by rst file key. As a drive-by, also shorten dir names with "advanced". Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: I61a4759b5ed41a3f99e7a2a9955c47f8b3fb3ed2 Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io> Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
* example_gallery: Restructure codeFriedemann Kleint2023-05-041-111/+112
| | | | | | | | | | Factor out a function writing one example and a string constant from main. Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: I5a1e7626d327c2424b8ec26f9618225d8bf8521e Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* example_gallery: Fix literalinclude for project filesFriedemann Kleint2023-04-281-3/+36
| | | | | | | | | | | | Make it possible to reference code snippets from the example by relative file names. This makes it possible to write tutorial examples. Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: Ie95d69c3f98be239e210c9c32b8fc9fb484639f4 Reviewed-by: Keith Kyzivat <keith.kyzivat@qt.io> Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* snippets_translate: Fix repetitive snippet ID linesFriedemann Kleint2023-04-272-16/+33
| | | | | | | | | | | | | | | | | | | | When writing consecutive snippets like // [1] line1 // [1] [2] line2 // [2] the line "// [1] [2]" would appear twice as end marker of snippet 1 and start marker of snippet 2, causing QtXmlToSphinx to extract an empty snippet for [2]. Fix by reconstructing the ID lines to use one ID per line. Task-number: PYSIDE-1106 Pick-to: 6.5 Change-Id: I0d7c0b30ff6bcc51c7d9ea6c9bfc844316a41c67 Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* tools: update missing bindings toolCristián Maureira-Fredes2023-04-063-21/+20
| | | | | | | | | | Refreshing the config and script for 6.5 Removing old requirements.txt file, because there is one inside the tool directory Change-Id: I1f15b65c71b311230cb32e027d8dcf2af8aba513 Pick-to: 6.5 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* doc: fix issues with pyside rst filesCristián Maureira-Fredes2023-04-051-0/+1
| | | | | | | | | | Fixing extra indentation, syntax issues, and formatting. Adapting too some snippet line highlights, and many other details. Pick-to: 6.5 Change-Id: Ife4eb5cec03577b2902d409b4007ae6d12141747 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* snippets_translate: Replace :: in switch/case valuesFriedemann Kleint2023-03-302-3/+3
| | | | | | | | | | Amends f9ed8662794d14b995b53c73ee18693a114e9773 Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: I774adaa377cba4bb8745c5ab86c1f52bead2ad86 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Christian Tismer <tismer@stackless.com>
* snippets_translate: Implement rudimentary switch() handlingFriedemann Kleint2023-03-282-0/+61
| | | | | | | Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: If19ac5a962aed846e4a127c652a9bae277999807 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* snippets_translate: Improve connect handlingFriedemann Kleint2023-03-282-3/+27
| | | | | | | | | | Extend the matching to recognize connects for member variables (m_ui.button), remove smart pointer accessor. Pick-to: 6.5 Task-number: PYSIDE-1106 Change-Id: Ib68df3d9d31a8de64059832c4c60ad4b20bf78e1 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* Example gallery tool: Enable per source file documentationFriedemann Kleint2023-03-271-0/+16
| | | | | | | | | | | Make it possible to specify a .rstinc per source file in the doc directory with explanations. Task-number: PYSIDE-1106 Pick-to: 6.5 Change-Id: I7b4fc3faf06e5233b619d036799b19f56f4ef6a7 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
* Example gallery tool: Add more file typesFriedemann Kleint2023-03-251-7/+13
| | | | | | | | | | As a drive-by, streamline the code. Task-number: PYSIDE-1106 Pick-to: 6.5 Change-Id: If996cb6f813a641fb4dd51cad2e41be3b26dcc07 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
* Example gallery tool: Fix repetitive "_" in generated file namesFriedemann Kleint2023-03-251-1/+1
| | | | | | | | Task-number: PYSIDE-1106 Pick-to: 6.5 Change-Id: I9760fc8ab7fac12cce059455811f906ec33dad49 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
* Deployment: cross-compile tool remove optionShyamnath Premnadh2023-03-241-1/+1
| | | | | | | | | - remove --no-examples option to align with ffb87075e3c4ea4b0a2dd15321af8c1921e33164 Task-number: PYSIDE-1612 Change-Id: Ia181330cd662ce2b353dfb0eff4bf69e09be50d0 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* doc: migrate to sphinx-design and update sphinxCristián Maureira-Fredes2023-03-171-29/+20
| | | | | | | | | | | | | | | | | | | | sphinx-panels is deprecated, and sphinx-design is the better replacement. This patch migrates everything we had in pyside and shiboken, which was useful to remove many CSS related hacks for things we were forcing before. The example gallery was also adapted to generate sphinx-design valid code. Additional adaptation to some examples and files were included as well, which improved the overall example experience. We used this to change to update sphinx as well, which before was not possible to update due to sphinx-panels. Fixes: PYSIDE-2244 Change-Id: Ia3f57f536591ea299bf87302e930203b64fafd7e Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* example_gallery: Add .webp image formatFriedemann Kleint2023-03-101-4/+2
| | | | | | | | | | As a drive-by, streamline the code. Task-number: PYSIDE-1106 Task-number: PYSIDE-2206 Change-Id: I8a3ac67aea073479a924d73dd34725c350982686 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* Android Deployment: Add Sdk path to toolchainShyamnath Premnadh2023-03-102-0/+6
| | | | | | | | | | - ANDROID_SDK_ROOT has to be set for compiling the essential Android java classes into Qt6AndroidBindings.jar. This .jar file will be shipped with the Android wheels. Task-number: PYSIDE-1612 Change-Id: I496f7578a6e104d947e6d643993a645c887151b4 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* Cross compile Qt for Python for AndroidShyamnath Premnadh2023-03-092-18/+144
| | | | | | | | | - uses a cross compiled Python to build Qt for Python wheels for a specified Android target platform Task-number: PYSIDE-1612 Change-Id: I3200e3cc749ef687ca62c0093065fbb23cd74cc8 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* doc: add zip file with examples to downloadCristián Maureira-Fredes2023-03-091-3/+31
| | | | | | | | | | | This adds a new functionality to the example gallery tool to create a ZIP file containing all the example files, and including a button to download it on each example page. Change-Id: I703c1d73bf690f2eaafca1012ccce3947e13a245 Task-number: PYSIDE-2246 Pick-to: 6.4 6.2 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* tools: python cross compileShyamnath Premnadh2023-03-063-0/+195
| | | | | | | | | | | | | | - script to cross compile Python for Android - Downloads CPython 3.9. For Python cross compilation, the host Python should match the target Python. python_for_android project packages the 3.9.9 interpreter along with the python application - Python script creates used jinja2 to create a bash script which run ./configure on CPython with various options Task-number: PYSIDE-1612 Change-Id: Ia50811d6f89a1ac6e8acaf5d7e9f3841a2851e3f Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* snippets_translate: Fix syntax errorFriedemann Kleint2023-03-021-1/+1
| | | | | | | | | | Amends 088acf9aec615372b297aab701757318e94b1fb5. Pick-to: 6.4 6.2 Task-number: PYSIDE-1106 Change-Id: I8b56874f5c686d11669b776f7398d0f9643e2bb5 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
* snippets_translate: Do not append "()" when assigning special valuesFriedemann Kleint2023-02-282-1/+6
| | | | | | | | | | | It used to generate things like "b = False()" for variable assignments. Check the special values. Pick-to: 6.4 6.2 Task-number: PYSIDE-1106 Change-Id: I19cdcd4205369d0d5681151b1f1243d6a9a3f81e Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Christian Tismer <tismer@stackless.com>
* snippets_translate: Fix new string literalsFriedemann Kleint2023-02-282-3/+3
| | | | | | | | | | | | Use a regexp to change u"s"_s to "s". Amends 4315cfb44eaa8abd57c685390c6b9d3aff09ba0f. Pick-to: 6.4 6.2 Task-number: PYSIDE-2151 Task-number: PYSIDE-1106 Change-Id: Id8a2cdee5966dfc4c5fbff9df6e7b9eeb7c0e436 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Christian Tismer <tismer@stackless.com>
* snippets_translate: Warn about possible errorsAdrian Herrmann2023-01-251-0/+1
| | | | | | | | | | | Display a message on top of pages that may contain automatically translated snippets. The message warns about possible errors in translation, and encourages readers to contribute or report errors. Pick-to: 6.4 Fixes: PYSIDE-2111 Change-Id: Ib76c9da5e11934676ab4b102649396cb43f98b92 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* missing_bindings : add comparison plotShyamnath Premnadh2022-12-192-1/+33
| | | | | | | | | - shows Qt API coverage comparison for each module, between Qt, PySide6 and PyQt6 Change-Id: Iac376908b34e9fc5f97890a3babb0d970fc65de3 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* Update missing bindings toolShyamnath Premnadh2022-12-151-20/+63
| | | | | | | | | | - add support for viewing modules present in PySide6, but not in PyQt6 Change-Id: Ia251e066a7ae2c6372ad778068ab61fb35b0533a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* snippets_translate: Improve handling of string literalsFriedemann Kleint2022-12-142-5/+18
| | | | | | | | | | | Add QStringLiteral and others and handle multiple occurrences per line better by making the patterns more discriminative. Pick-to: 6.4 6.2 Task-number: PYSIDE-2151 Task-number: PYSIDE-1106 Change-Id: I37589dfafe27d69480db665363d5900d163014da Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
* Update missing_bindingsShyamnath Premnadh2022-12-051-3/+3
| | | | | | | | - update PySide6 version from 6.3 to 6.4 Pick-to: 6.4 Change-Id: I425c0c1cd375d560b9f22a0d7a2f715ef2d5f320 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* snippets_translate: Fix the license handlingFriedemann Kleint2022-11-261-29/+27
| | | | | | | | | | | Adapt to SPDX licenses, leave the old code path as is. As a drive-by, avoid reading the snippets file twice. Pick-to: 6.4 6.2 Task-number: PYSIDE-1106 Change-Id: Ia518124b09e22d01e37970f30605d94b86123106 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Christian Tismer <tismer@stackless.com>
* Fix snippets_translate on Windows, take 2Friedemann Kleint2022-11-231-10/+14
| | | | | | | | | | | Fix another occurrence of opening a file. Amends ed0f55c1d79636040843ae5c5e0d9308e35da65a. Pick-to: 6.4 Change-Id: I7b1fa6068b620acafe51df539ad9379d922277b1 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io> Reviewed-by: Christian Tismer <tismer@stackless.com>
* Fix snippets_translate on WindowsFriedemann Kleint2022-11-221-5/+10
| | | | | | | | | Force UTF-8 encoding. As a drive-by, use Pathlib methods. Complements 81d81baf0ef6c42ebdb6a2b2293d09031ce6dd5c. Pick-to: 6.4 Change-Id: Iccdb33429a030ec76dc55699b07210cd533ba7c2 Reviewed-by: Christian Tismer <tismer@stackless.com>
* example_gallery: Check if a file existsVenugopal Shivashankar2022-11-161-2/+9
| | | | | | | | | | The files in the pyproject could be missing in some cases, so a check is required before appending to the files list. Pick-to: 6.4 Change-Id: Ifc70eebacb35b72d8a9713a8bf75b321284906ff Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>