diff options
| author | Mårten Nordheim <marten.nordheim@qt.io> | 2025-06-19 13:18:42 +0200 |
|---|---|---|
| committer | Mårten Nordheim <marten.nordheim@qt.io> | 2025-07-28 18:50:50 +0200 |
| commit | adb18ad479d0fbdfed1399740d01314119ce9e36 (patch) | |
| tree | b8aa036afcfa139e8b1302f20ad258a3480c36bb | |
| parent | 8d6ffc4b529fcd402eafa55770d144dc34f4e2df (diff) | |
CRA[plugins/tls]: Mark most of it critical
The files all deal with cryptography in one way or another,
some more directly than others.
Task-number: QTBUG-135730
Pick-to: 6.10 6.9 6.8
Change-Id: If4a7bba92de5f4577876623c403379008008643a
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
| -rw-r--r-- | src/plugins/tls/openssl/qdtls_openssl.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/openssl/qsslcontext_openssl.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/openssl/qssldiffiehellmanparameters_openssl.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h | 1 | ||||
| -rw-r--r-- | src/plugins/tls/openssl/qtls_openssl.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/openssl/qtlskey_openssl.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/openssl/qx509_openssl.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/schannel/qtls_schannel.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/schannel/qtlskey_schannel.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/securetransport/qtls_st.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/securetransport/qtlskey_st.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/shared/qasn1element.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/shared/qsslsocket_qt.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/shared/qtlskey_generic.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/tls/shared/qx509_generic.cpp | 1 |
16 files changed, 16 insertions, 0 deletions
diff --git a/src/plugins/tls/openssl/qdtls_openssl.cpp b/src/plugins/tls/openssl/qdtls_openssl.cpp index ac0e81eb08f..9153da2bdba 100644 --- a/src/plugins/tls/openssl/qdtls_openssl.cpp +++ b/src/plugins/tls/openssl/qdtls_openssl.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2018 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include <QtNetwork/private/qnativesocketengine_p_p.h> diff --git a/src/plugins/tls/openssl/qsslcontext_openssl.cpp b/src/plugins/tls/openssl/qsslcontext_openssl.cpp index 4e141682d5b..1902416fedc 100644 --- a/src/plugins/tls/openssl/qsslcontext_openssl.cpp +++ b/src/plugins/tls/openssl/qsslcontext_openssl.cpp @@ -3,6 +3,7 @@ // Copyright (C) 2014 Governikus GmbH & Co. KG. // Copyright (C) 2016 Richard J. Moore <rich@kde.org> // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include <QtNetwork/qsslsocket.h> #include <QtNetwork/qssldiffiehellmanparameters.h> diff --git a/src/plugins/tls/openssl/qssldiffiehellmanparameters_openssl.cpp b/src/plugins/tls/openssl/qssldiffiehellmanparameters_openssl.cpp index 16e31e605fb..fcf5b1d8bbd 100644 --- a/src/plugins/tls/openssl/qssldiffiehellmanparameters_openssl.cpp +++ b/src/plugins/tls/openssl/qssldiffiehellmanparameters_openssl.cpp @@ -1,6 +1,7 @@ // Copyright (C) 2015 Mikkel Krautz <mikkel@krautz.dk> // Copyright (C) 2016 Richard J. Moore <rich@kde.org> // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include "qsslsocket_openssl_symbols_p.h" #include "qtlsbackend_openssl_p.h" diff --git a/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp b/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp index 1ddf9ce2850..a5e3a3caf9b 100644 --- a/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp +++ b/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp @@ -2,6 +2,7 @@ // Copyright (C) 2014 BlackBerry Limited. All rights reserved. // Copyright (C) 2016 Richard J. Moore <rich@kde.org> // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:execute-external-code /**************************************************************************** ** diff --git a/src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h b/src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h index a93c110b3f7..ab7bd1fd0ac 100644 --- a/src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h +++ b/src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h @@ -1,6 +1,7 @@ // Copyright (C) 2017 The Qt Company Ltd. // Copyright (C) 2014 BlackBerry Limited. All rights reserved. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:execute-external-code /**************************************************************************** ** diff --git a/src/plugins/tls/openssl/qtls_openssl.cpp b/src/plugins/tls/openssl/qtls_openssl.cpp index 57d09a649b1..db9661b8c15 100644 --- a/src/plugins/tls/openssl/qtls_openssl.cpp +++ b/src/plugins/tls/openssl/qtls_openssl.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2021 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include "qsslsocket_openssl_symbols_p.h" #include "qx509_openssl_p.h" diff --git a/src/plugins/tls/openssl/qtlskey_openssl.cpp b/src/plugins/tls/openssl/qtlskey_openssl.cpp index 294fc2ffcd9..f84461fd78b 100644 --- a/src/plugins/tls/openssl/qtlskey_openssl.cpp +++ b/src/plugins/tls/openssl/qtlskey_openssl.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2021 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include "qsslsocket_openssl_symbols_p.h" #include "qtlsbackend_openssl_p.h" diff --git a/src/plugins/tls/openssl/qx509_openssl.cpp b/src/plugins/tls/openssl/qx509_openssl.cpp index 21c81b105de..aba3efa1a6b 100644 --- a/src/plugins/tls/openssl/qx509_openssl.cpp +++ b/src/plugins/tls/openssl/qx509_openssl.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2021 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include "qsslsocket_openssl_symbols_p.h" #include "qtlsbackend_openssl_p.h" diff --git a/src/plugins/tls/schannel/qtls_schannel.cpp b/src/plugins/tls/schannel/qtls_schannel.cpp index 7e6a372347e..12c2625f39d 100644 --- a/src/plugins/tls/schannel/qtls_schannel.cpp +++ b/src/plugins/tls/schannel/qtls_schannel.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2021 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography // #define QSSLSOCKET_DEBUG diff --git a/src/plugins/tls/schannel/qtlskey_schannel.cpp b/src/plugins/tls/schannel/qtlskey_schannel.cpp index eb0a2371ab1..6dce0b92c22 100644 --- a/src/plugins/tls/schannel/qtlskey_schannel.cpp +++ b/src/plugins/tls/schannel/qtlskey_schannel.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2021 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include <QtNetwork/private/qssl_p.h> diff --git a/src/plugins/tls/securetransport/qtls_st.cpp b/src/plugins/tls/securetransport/qtls_st.cpp index ff431dabd17..f136de7ef7a 100644 --- a/src/plugins/tls/securetransport/qtls_st.cpp +++ b/src/plugins/tls/securetransport/qtls_st.cpp @@ -1,6 +1,7 @@ // Copyright (C) 2021 The Qt Company Ltd. // Copyright (C) 2014 Jeremy Lainé <jeremy.laine@m4x.org> // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include "qtls_st_p.h" #include "qtlsbackend_st_p.h" diff --git a/src/plugins/tls/securetransport/qtlskey_st.cpp b/src/plugins/tls/securetransport/qtlskey_st.cpp index db4187ee032..bc248b799f2 100644 --- a/src/plugins/tls/securetransport/qtlskey_st.cpp +++ b/src/plugins/tls/securetransport/qtlskey_st.cpp @@ -1,6 +1,7 @@ // Copyright (C) 2021 The Qt Company Ltd. // Copyright (C) 2014 Jeremy Lainé <jeremy.laine@m4x.org> // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include "qtlskey_st_p.h" diff --git a/src/plugins/tls/shared/qasn1element.cpp b/src/plugins/tls/shared/qasn1element.cpp index 4ad3e1351a1..8e46ea476c3 100644 --- a/src/plugins/tls/shared/qasn1element.cpp +++ b/src/plugins/tls/shared/qasn1element.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2014 Jeremy Lainé <jeremy.laine@m4x.org> // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:data-parser #include "qasn1element_p.h" diff --git a/src/plugins/tls/shared/qsslsocket_qt.cpp b/src/plugins/tls/shared/qsslsocket_qt.cpp index 7e108dceca4..3c920ba3a27 100644 --- a/src/plugins/tls/shared/qsslsocket_qt.cpp +++ b/src/plugins/tls/shared/qsslsocket_qt.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2014 Jeremy Lainé <jeremy.laine@m4x.org> // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:cryptography #include "qasn1element_p.h" diff --git a/src/plugins/tls/shared/qtlskey_generic.cpp b/src/plugins/tls/shared/qtlskey_generic.cpp index 5813c32e7f8..571ae52a723 100644 --- a/src/plugins/tls/shared/qtlskey_generic.cpp +++ b/src/plugins/tls/shared/qtlskey_generic.cpp @@ -1,6 +1,7 @@ // Copyright (C) 2014 Jeremy Lainé <jeremy.laine@m4x.org> // Copyright (C) 2021 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:data-parser #include "qtlskey_generic_p.h" #include "qasn1element_p.h" diff --git a/src/plugins/tls/shared/qx509_generic.cpp b/src/plugins/tls/shared/qx509_generic.cpp index 5006db1a725..ff8dbe131c4 100644 --- a/src/plugins/tls/shared/qx509_generic.cpp +++ b/src/plugins/tls/shared/qx509_generic.cpp @@ -1,5 +1,6 @@ // Copyright (C) 2021 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:data-parser #include <QtNetwork/private/qsslcertificate_p.h> #include <QtNetwork/private/qssl_p.h> |
