summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Revert "qdbusxml2cpp: invert Q_DECL_DEPRECATED and inline in the output"v6.5.06.5.0Fabian Kosmale2023-03-251-7/+5
| | | | | | | | | | This reverts commit 310f6666150f18d40630b54cf5c9424e4cfb5567. Reason for revert: Causes a fail-to-build regression Task-number: QTBUG-111330 Change-Id: I08a6a68d2c81e1a1189356aa7cf36aaf24fd8c9b Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* QVariant: ensure the type custom is registered on constructionThiago Macieira2023-03-241-0/+1
| | | | | | | | | | | | | | | I must have broken this in the 6.5 work I did for QMetaType and QVariant, but I haven't searched which commit exactly did it. Our QVariant tests are old and thus only checked the type ID, which meant that they caused the registration by the act of asking for the ID in the first place; this commit adds a couple of explicit checks for the type registered by name before the ID. Fixes: QTBUG-112205 Change-Id: Idd5e1bb52be047d7b4fffffd174f1b14d90fd7a3 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 8570e86fff183ffa4c1dff577c7fa14e3342daee) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QSQL/ODBC: fix regression (trailing NUL)Marc Mutz2023-03-231-2/+4
| | | | | | | | | | | | | | | | | | | | | When we fixed the callers of toSQLTCHAR() to use the result's size() instead of the input's (which differ, if sizeof(SQLTCHAR) != 2), we exposed callers to the append(0), which changes the size() of the result QVLA. Callers that don't rely on NUL-termination (all?) now saw an additional training NUL. Fix by not NUL-terminating, and changing the only user of SQL_NTS to use an explicit length. Amends 4c445ef0bae8b36ec4a742552f0ebd81a1a90723 and 46af1fe49f7f419dc1b3231de9860e2da0ea48f8. Done-with: Christian Ehrlicher <ch.ehrlicher@gmx.de> Change-Id: I6210b77e9417f46294df94cb32ab4134af8dc4c2 Reviewed-by: Andy Shaw <andy.shaw@qt.io> (cherry picked from commit 9020034b3b6a3a8118e5959beed699bb8aaa3f95) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* wasm: Text input hotfixMikolaj Boc2023-03-231-0/+4
| | | | | | | | | Focus the canvas on window activation to make the screen receive key events. Fixes: QTBUG-111848 Change-Id: Iad3474681653b176eebd901aaf59e84538681351 Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Fix FTBFS with -qtnamespaceMårten Nordheim2023-03-191-1/+3
| | | | | | | | | | | | | qtbase/src/corelib/kernel/qvariant.h(54): error C2888: 'const bool qIsRelocatable<qt::QVariant>': symbol cannot be defined within namespace 'qt' Amends 0ca803a5d325f26f5e4e0fcab8b9c9a02f154336 Fixes: QTBUG-112016 Change-Id: I43b3f292fa85b6cda00f36da6c8aff65da4ed742 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit c0a732f984f407f7613805ff04b8a6d46c12f754)
* SQLite: Update SQLite to v3.41.1Christian Ehrlicher2023-03-193-39/+92
| | | | | | | | | [ChangeLog][QtSQL][SQLite] Updated SQLite to v3.41.1 Change-Id: Ibc88ae7b73ea46797d7aff00ee193b1ccfaae31b Reviewed-by: Andy Shaw <andy.shaw@qt.io> (cherry picked from commit 17e4b2d8ed8fc6c05e9ce66d39f0eff5a768cbd6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* androiddeployqt: remove infinity loop in deleteMissingFilesBartlomiej Moskal2023-03-161-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a possibility of infinite loop and eventually crash when androiddeployqt was used for the second time. Everything because of deleteMissingFiles function for clean up previous build. When we find the same names and those are directories, we call recursively deleteMissingFiles. The parameters we use are absoluteDir, not absoluteFilePath. As we use parent of found dir, deleteMissingFiles is called with the same values as before. This commit removes possibility of infinite loop by using absoluteFilePath. That allows to avoid calling deleteMissingFiles with the same parameters. There is still a possibility, that directory that was found is not the same as we were looking for. That will cause not needed files removing, but those file will be copied again later. This regression was created by 7dc05252a0df829bb5ea3994160d425bb0da26cb commit Fixes: QTBUG-111027 Change-Id: I195b4c407068b14e2ef94800ad1945adc66408cb Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> (cherry picked from commit f4d897f04eee6386382096945f872ae9f306a5de) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit b0553d15a06c9a842e82caf8ce62530bd45d888c) Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io>
* QMetaType: Ensure that qfloat16 gets correct idFabian Kosmale2023-03-131-0/+14
| | | | | | | | | | | | | | | | | | Code initially compiled against Qt <= 6.2 does not have a qfloat16 metatype that unconditionally gets registeret from QtBase. Therefore, any preexisting metatype instance for qfloat16 will hit the custom type registry code path. As builtin metatypes are not part of the custom registry, we will create a new type-id, and the type will thus not compare equal to new code using the builtin type-id. Avoid this issue by inserting an alias to the type in QMetaTypeCustomRegistry's constructor. Pick-to: 6.5 dev Change-Id: I825265ad16e274c08b2c4a3a4814475b6c6c6187 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Fix listed files for sha3_keccakKai Köhne2023-03-131-1/+1
| | | | | | | | | | | | JSON allows duplicated fields, but the last one will prevail. Therefore move the new "comment" before the actual list of files. Amends fa4b7495b741c3e7943860c5ff15212afceda710. Change-Id: I06874745c8c51e55d79d7a373236cc8d9151079d Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit d4dba80863324302f9d5d26b184352845263adc3) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QVariant: fix comparisons between strings and integer 0Giuseppe D'Angelo2023-03-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | 250ca8d5f8bb3771695ae8eccb8d9b469003d840 changed the qConvertToNumber to have a std::optional return instead of a boolean out-argument. In doing so a code path that was supposed to report a failure (string could not be converted to an integer) accidentally starting reporting success (and converting the string to 0). The problem is that the `ok` check from QString::toLongLong was accidentally dropped in the refactoring; previously the function set `ok` to false and returned 0, now the function just returns 0. Instead, amend that return to return nullopt (because the conversion has failed). Change-Id: Iaedef5463f3ec500a97bd4c9bbddf977f66df61a Fixes: QTBUG-111867 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit a25644aecf056b9b021189de5384519b6f06c1e6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Make it possible to use QObjectPrivate::connect in private codeVolker Hilsheimer2023-03-102-2/+12
| | | | | | | | | | | | | | | | | | | | | In most QObjectPrivate-subclasses, the Q_DECLARE_PUBLIC macro is used in the private segment of the class declaration. In that case, the q_ptr becomes a private member of the private class, and then the QObjectPrivate::connect function can no longer be used, as it needs to access the d_ptr. Fix this by declaring QObjectPrivate, and the static-assert-helper, as friends of the class using the Q_DECLARE_PUBLIC macro. Adapt the QObject test by moving the Q_DECLARE_PUBLIC macro into the private section of the test-private, and add a compile test. Change-Id: Ifc04be3b305221e138b1e08bb3a3838d871f4fcb Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 4f02973e2f447dfc92234ec247d7157ea0e1e807) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix overflow in SHA-3/KeccakMårten Nordheim2023-03-103-2/+35
| | | | | | | | | | | | | state->rate is always larger than or equal to state->bitsInQueue; when bitsInQueue == rate the queue is consumed and bitsInQueue is set to 0 again. Done-with: Marc Mutz <marc.mutz@qt.io> Change-Id: I56d268a19fb3cd542cc027edc962253f09d97a14 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit fa4b7495b741c3e7943860c5ff15212afceda710) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: fix more links to cmake functionsVolker Hilsheimer2023-03-104-9/+11
| | | | | | | | | | Use qt6_ consistently as the link target, and qt_ when referring to the function. Change-Id: I9bb903cd2c32dcded1ee7a2804aa36074e8a5c38 Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io> (cherry picked from commit 454dafb0e1a36ef6bbe9eafc240c22f6cd14e312) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QTypeInfo: move helpers in QtPrivate namespaceGiuseppe D'Angelo2023-03-102-5/+9
| | | | | | | | | | qIsRelocatable and qIsValueInitializationBitwiseZero are not public API, hide them away. Change-Id: Ib4eeaab46d01759098e96091b700e9a28fd50962 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 0ca803a5d325f26f5e4e0fcab8b9c9a02f154336) Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Make compare(QU8SV) a non-template, document itMarc Mutz2023-03-105-26/+75
| | | | | | | | | | | | | | | | | Templates have different overload characteristics from normal functions, and treating q_no_char8_t and q_has_char8_t::QUtf8StingView separately is never necessary, as one implicitly converts into the other. Add docs for the new UTF-8 compare() functions. Amends b977ae371a753a82e1d0bb32c5b62099da663721. Found in API review. Change-Id: I58b4b28a3eccde1976d71cfa3412b734d46f314d Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit bbb9cf225fd030a87818cb867c24ab651f797100)
* QCborValue: add missing Q_DECLARE_OPERATORS_FOR_FLAGSThiago Macieira2023-03-091-0/+2
| | | | | | | | Change-Id: Ib1d2fc7100134f7597cdfffd174a650ccda287ea Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit 06f60b24e23a9aa6640608f6010137ed75e2841e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Update docs to reflect method being renamedAndreas Eliasson2023-03-092-4/+4
| | | | | | | | | | The new method has been renamed from markDirty to notify. Fixes: QTBUG-111267 Change-Id: Ib7926a315cfd11ca6930c785290089b7031d34ff Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 12c62dd243dd139023fa1fc5c3a7c0fd8e3ee0ba) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Plumb QMessageBox::setCheckBox() through QPlatformMessageDialogHelperTor Arne Vestbø2023-03-097-16/+62
| | | | | | | | | | | | | | | | | | | | | | | | Without this plumbing we have no way of knowing if the QMessageBox has a checkbox set, and can't decide to skip the native dialog, leaving the user without the expected checkbox. As the suppression checkbox on macOS can be customized, we can use this plumbing to actually provide native dialog support for generic check boxes. This mechanism can also be used by QErrorMessage, which now matches behavior between native and non-native dialogs in terms of the label of the checkbox and its initial state. We might want to tweak this in the future, since user's might expect the suppression label and state to match the system default, but that's something we can expose from the platform theme if so, and should apply equally to the non-native dialog. Fixes: QTBUG-111803 Change-Id: Ied9fc34383fe79fbd8437592ad1c1993b9396178 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit a0313c85a9b8ab6ba0ec273f0c8638e2f7b8cc18) Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* QErrorMessage: Reset 'again' check box between each error messageTor Arne Vestbø2023-03-091-0/+1
| | | | | | | | | | | | | | | | The choice of whether to show a message again is per message, so when showing a new message we need to reset the check box back to its default checked state, otherwise the user might mistakenly dismiss more than the indented message. [ChangeLog][Widgets] QErrorMessage will now reset the check box for showing a message again for each new message shown, as each individual message has its own suppression state. Change-Id: I86d4bb5eabdb5b7a478c03516108a5edf87fcbe3 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit f2fc2013defc2f346fa1936dcf357d34bae3dbba) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Fix keyword for CMake commands related to deploymentJoerg Bornemann2023-03-083-3/+3
| | | | | | | | | | The pages are supposed to use the \keyword command to provide a target for the versioned command name. Change-Id: Ic91f5becc80985622a691aba96ce2c4e2984078e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 565e43fc704919923e53103911a72b3fec5c9d16) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: use () in references to cmake functionsVolker Hilsheimer2023-03-082-3/+3
| | | | | | | Change-Id: Ia4177a293c9c93edb8f27aec237df45b98caf20d Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> (cherry picked from commit a9427bedd48cf978fcc8c24c5da14a9b79326c71) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* macOS: Use non-native app modal message box from nested event loopsTor Arne Vestbø2023-03-071-0/+5
| | | | | | | | | | | | The NSAlert does not stay open when ran from a nested event loop, so we need to fall back to the cross platform dialog. The window modal dialog does not have this issue. Fixes: QTBUG-111524 Change-Id: I63fba0a092018bb19edeef78c06587455d752235 Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io> (cherry picked from commit 4e59a5252c11738ce4849032a5aa2a23f97a18ed) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: fix QOpenGLWidget::defaultFramebufferObject documentationVolker Hilsheimer2023-03-071-7/+5
| | | | | | | | | | | | | Fix the link to QSurfaceFormat::StereoBuffers, and clean the text up a bit. If everything is a \note, then we might just as well not have notes, so move the statement about when this function is useful out of a note, and combine the statements elaborating on ownership and lifetime of framebuffer and contexts into a single note. Change-Id: I7cb1f9ff78ba760e99d639550130f5c833ad684a Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> (cherry picked from commit 47df0eb5131a5fc0decd049bd3f9eefeb26276df) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Fix syntax errorVolker Hilsheimer2023-03-071-1/+1
| | | | | | | | | Amends e0ecb0ded21082f4e00ee77411339009cb1294a4 Change-Id: If315d97e93047a8bece36c727c7646d30eb7458b Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io> (cherry picked from commit 3ff66569eac5737af56a5bf910cbc2970d7312f0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: fix link to QTest::failOnWarningVolker Hilsheimer2023-03-072-4/+4
| | | | | | | | | | Also fix incorrect failOnWarning*s* elsewhere in comments. Change-Id: I0bbc5e71060348153876f3d9a7c77c67f3c2e00d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> (cherry picked from commit 9e31631557ea3f99506377ff91a1e15e942f9e88) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: fix links to changed or renamed i18n pages and sectionsVolker Hilsheimer2023-03-072-3/+4
| | | | | | | Change-Id: Ibe00b793ae0943cdbbcfa272e5cae4e91da5bf7d Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> (cherry picked from commit 2e6de6f8b27f4a3ed2fbaf2e393614ee8f09a043) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* qsimd_p.h: remove LZCNT feature from the ARCH_HASWELL listThiago Macieira2023-03-051-2/+2
| | | | | | | | | | | | | | | | | | And for good measure, I'm also removing BMI2. The one we really care about ensuring gets enabled instead of -mavx2 is FMA anyway. Complements commit 29d3938aa56663f09666a0ac58b33e70e00abff2 (which in turn complemented commit a98cf15ed1b57aee695de01b04a974637b2cd44a), which removed BMI1 because AMD introduced it before AVX2. Looks like they also introduced LZCNT in some earlier processor too (family 10h) or GCC 12 began emitting __LZCNT__ for that family -- IIRC the AMD feature list was bigger than just the lzcnt instruction. Fixes: QTBUG-111698 Change-Id: I7f354474adce419ca6c2fffd1748f5b24f69a692 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 8413824ca00188fa36b6adf46d4a5bddb9515ec7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: fix links to qFuzzyIsNullVolker Hilsheimer2023-03-052-2/+2
| | | | | | | | | The function is in the QtNumeric documentation context. Change-Id: Ibc6a8961bc04efd4ab1eb50bb371e6a169d513dc Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> (cherry picked from commit c1cbb12e57e24b977b1a5c5be711793d6e67c113) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: fix qdoc warning, explicitly qualify enum typeVolker Hilsheimer2023-03-051-1/+1
| | | | | | | Change-Id: Ie289f2468a3a71d35696907691586a31f70d5b1e Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> (cherry picked from commit d48dbafeb24ee82ad6b97e8e5e9c9fcaa5f8a2d4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix build with -no-feature-lineeditTasuku Suzuki2023-03-052-6/+11
| | | | | | | | | Introduce a new feature for password dialog in cups that needs several widgets Change-Id: I93799b814ac06e661c19cffcd7d3c9bfa56ff814 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 45df0ed2462beefce1aa51abf3cda7bc18e52118) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc fix in QIntValidator::validate() and comment on a testEdward Welbourne2023-03-051-6/+6
| | | | | | | | | | | | | | The doc said positive values for a negative range were intermediate but the code actually rejects them if the value has an overt plus sign, so make clear that intermediate is only for the case without a sign. Incidentally comment on a test where it might not have been obvious to the reader that a space is the locale's digit-grouping chracter. Change-Id: I3edab74fe8c2cbe8448c0e523676f1fd0d0d8a9f Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 58f5ec35f108bca01489124e74e96018fd937ed4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Simplify and relax UTF-8 locale override machinery for DarwinEdward Welbourne2023-03-051-6/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's no need to try the various permutations of the language and region specific locales, as they all point back to the same CTYPE in /usr/share/locale/UTF-8/LC_CTYPE In addition, processes started from launchd come with an empty locale environment (LC_ALL/LC_*/LANG), and hence will default to the "C"/POSIX locale, even after picking up the environment. This primarily applies to applications launched from Finder, but also affects processes launched as background services. And since a child process will inherit its parent's environment the empty locale environment is propagated when running apps from IDEs such as Qt Creator or Xcode, or commands in an SSH login session (as sshd is a background service), unless the environment has been explicitly set up by the shell (Zsh). Since neither of these situations is the result of user misconfiguration, it makes little sense to spit our a warning. We however still warn if we detect that the character encoding has changed from the default "C" encoding, or if the encoding is "C", but we detect that the user has modified any of the relevant locale environment variables, as this indicates either a change in the system default behavior, or that the user has explicitly requested a "C" locale, which is wrong. Done-with: Tor Arne Vestbø <tor.arne.vestbo@qt.io> Fixes: QTBUG-111443 Change-Id: I6fd14d1f8adddc2914d6ff4d3b5ad34a3871ef82 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> (cherry picked from commit ac6c7aa12fb6203855a745b2c1b4a1e07149b4af)
* QCoreApplication::initLocale(): Improve warning on failureEdward Welbourne2023-03-051-8/+18
| | | | | | | | | | | | | | | | | | | | | | If we fail to set a UTF-8 locale, the warning claims Qt shall use a UTF-8 locale, for which it reports an empty string, when in fact it isn't using a UTF-8 locale, although it'll interact with the system as if it were. Also, the user is liable to understand "system locale encoding" as referring to the underlying system rather than whatever they may have configured in a local shell; and a non-native speaker assures me the use of "shall" is also apt to confuse; so reword the messages. As the old locale is only needed for the code path prints the warning we can defer resolving it until we know we're going to use it, by querying the locale at that point. Done-with: Tor Arne Vestbø <tor.arne.vestbo@qt.io> Change-Id: Ie6a6e7a707200e58335fcb64cb1584f0c307895a Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> (cherry picked from commit fff9395c2899841bdca07f400392595963d9ff93) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* GL paint engine: Fix drawPixmapFragments when using buffer objectsLaszlo Agocs2023-03-051-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Until recently the buffer object-based code path (so not client-side pointers) was only hit with a core profile context. This changed at some point in 6.4 and later to support WebGL (that has no client-side pointers, unlike OpenGL ES 2.0 it is based on). Now buffer objects are preferred over client-side pointers, always. Problem is, drawPixmapFragment() was never functional on this code path, it seems. Expecting that transferMode() does all the uploadData() needed is wrong. transferMode() bails out if the mode is the same as before, and that's exactly what happens when an application calls drawPixmapFragments() on the painter twice, after each other. How exactly this works with client-side pointers is not fully clear, but presumably the data buffer address stays the same so all pointers passed in to the glVertexAttribPointer calls are valid, and it sources the data for each draw call (probably), thus the rendering is all correct even though only the first, not the second, drawPixmapFragment() led to calling uploadData() internally. Amends e487b07e18f1cb7ff126744be57b2ae1b9839c6c although this patch on its own is just as applicable pre-6.4 as well (to fix drawPixmapFragments when using a core profile context). Fixes: QTBUG-111416 Change-Id: I2ad358424e613192a51b99b937aef7660f5dbe08 Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io> (cherry picked from commit d6c5a2f9177f427d14aae64d111c172d1bf28b6c) Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
* Remove the 'sdi' exampleVolker Hilsheimer2023-03-032-2/+2
| | | | | | | | | | | | It is essentially the same as the other mainwindow examples, showing how to create a text editor. The only special code here is the tiling of the different main windows, which - without any documentation or explanation - is neither very helpful, nor relevant in 2023. Change-Id: I48b92b1cf057f586e0d2842d1c0a3312154e9a13 Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit 3c104c279911419f3d0a9e6f3ac050e6f3968e7e) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* QDebug: fix std::string/view stream operators; add u8 versionsMarc Mutz2023-03-032-77/+58
| | | | | | | | | | | | | | | | | | | | | | | Make them templates, for two reasons: - so they can accept std::pmr types and, in general, any basic_string with custom allocators and char_traits - to break overload ambiguities with the Qt string view types Also, add the missing C++20 char8_t overloads. Also, avoid creation of a QString in the sizeof(wchar_t) == 2 case (Windows). Add a comment to optimize for the sizeof(wchar_t) != 2 case later. Found in API review. Change-Id: I30139520f582a38863a0936f8eca4b1ed33e37c8 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit 52c7f699ac3124889b9c01fbc1fd542e30da6753) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Doc: fix link to XML Streaming pageVolker Hilsheimer2023-03-031-1/+1
| | | | | | | Change-Id: Ibc8e869e140e25d7f90bd8ff922918afb3935e42 Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit c9dc3d7427919bc9496c1d222a29cd96955ea597) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Tidy up QCoreApplicationPrivate::initLocale()'s #if-eryEdward Welbourne2023-03-031-12/+20
| | | | | | | | | | | | | | | | | | Explain each exception cleanly and as itself, thereby avoiding the need for long and tangled #if-ery conditions. Make sure to setlocale(LC_ALL, "") everywhere we think we have initialized the locale, including Integrity - it plainly has setlocale(), since we call it for LC_CTYPE - since we should at least give it the chance to set its implementation-defined default locale, instead of the standard-defined POSIX locale in use on entry to main(). Done-with: Tor Arne Vestbø <tor.arne.vestbo@qt.io> Change-Id: Iab00984ba45dfc9a324b6a3c12e3d330b655a5a9 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> (cherry picked from commit 91bea4470ea25c1e6fe7e46559a37bdd7b703b63) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* qobjectdefs.h: properly disable rvalue qReturnArg()Marc Mutz2023-03-031-1/+1
| | | | | | | | | | | | | | | | | | | template <typename T> qReturnArg(T&&) is an unconstrained perfect forwarder, and will "win" for everything for which `T&` is not an equal match. e.g. a volatile T. Restrict the deleted overload to actual rvalues. We don't need to use `const volatile T&&`, because rvalues never bind to `T&`, we just need to get off using a universal reference, and adding const does that. As a drive-by, change the deleted overload's return type to void, to mimic std::as_const(), the prototype for rvalue-deleted function overloads. Change-Id: If4fbc311677b993488859b2c4e226b94daed71fe Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit c6dbae9550e3819a3e1ade1bf06f5d9cb030d561) Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* QBasicTimer: replace new qint64 overloads with chrono onesMarc Mutz2023-03-033-29/+41
| | | | | | | | | | | | | | | | Found in API review. As per "chrono first" initiative[1], implement the int overload via the chrono one, not vice versa [1] https://lists.qt-project.org/pipermail/development/2023-January/043563.html Change-Id: I65fe7039ad8ae5f9eb21d9c59a46b9c5c152fac3 Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit 5573e2d6ac09ff8b8f23edca93f601ff7679fa3c) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Doc: point at tetrix example for QBasicTimer usageVolker Hilsheimer2023-03-012-3/+3
| | | | | | | | | | The wiggly example is gone, but tetrix shows how to use QBasicTimer as well. Change-Id: Iaad78b0d7e2136ef41d98f634d0680e6f7f3c4e1 Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit b7b712181bd47a84640a655100661c4aa008c6e9) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: move snippet for implicit translation contextVolker Hilsheimer2023-03-011-1/+1
| | | | | | | | | | The 'sdi' example is a candidate for removal, so point at the spreadsheet example instead, which is not. Change-Id: I4405f2421db8be79898a38ca4f3fa1ea5fe0280b Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit 721b4a4b5a8b4e16d50690e0d9ca62725c3ddafb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: fix link to Widgets TutorialVolker Hilsheimer2023-03-011-1/+1
| | | | | | | | | It's been a while since we had a single Tutorial for all of Qt. Change-Id: I7317291c445c09b0bf728513670b6a575dd536bc Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit a776aea7aacfcb11a14afcb4fe8cd3edfbf86b37) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* doc: Fix spelling of 'equivalent' in QString documentationTor Arne Vestbø2023-03-011-3/+3
| | | | | | | Change-Id: I1d39bee80fbaf3e3e6eb5e383fd845bb0f9071e5 Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io> (cherry picked from commit 3154aec540b29827173d9de0ef7aad30849e6890) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* qobjectdefs.h: optimize AreOldStyleArgsMarc Mutz2023-03-011-3/+3
| | | | | | | | | | | Use a template alias instead of C++98-style inheritance. Saves one template instantiation. Change-Id: I95ee9cf1e5eac1db5fc8e05cd95f5e745134214d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit b37b820ce8801613139241036d15baa581a6a403) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Apply q20::remove_cvref_t around the codeMarc Mutz2023-03-014-11/+11
| | | | | | | | | | Found in API review. It's not BC-critical, but let's get this into 6.5 to minimize the diff to our future LTS. Change-Id: Iaa63afad1d31f6edef29e1185897d925f47a094d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit ebb833d7f70465844e474583571770ad14adcebf) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Android: fix and document QStandardPaths behavior on different versionsAssam Boudjelthia2023-03-012-15/+78
| | | | | | | | | | | | | | | | | Partially revert e1440dd7bc1a5da9a536f88b9733d04ec8fa6e61 for Android versions below 11 which could take advantage of the manifest flag android:requestLegacyExternalStorage. And for other newer versions avoid returning them while adding a note to the docs about this behavior. Fixes: QTBUG-108013 Fixes: QTBUG-104892 Task-number: QTBUG-81860 Change-Id: I10851c20e2831bddaa329164c941e2ae71f0a497 Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io> Reviewed-by: Rami Potinkara <rami.potinkara@qt.io> (cherry picked from commit 81a748efb742092f5a0a1c33b8340478e52cc79f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QVarLengthArray: move a static_assert() to the correct placeMarc Mutz2023-03-011-1/+1
| | | | | | | | | | | | | | | Having the Prealloc > 0 assertion only in the QVLA(qsizetype) ctor makes no sense. Prealloc > 0 is mandated by the class as a whole, not that particular ctor, so we shouldn't delay the assertion to the instantiation of this ctor. Move it to class scope instead, alongside the assertion for nothrow-destructible. Change-Id: I0225a4533841e5b433a3d9781b2642c084f775ab Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> (cherry picked from commit 0f447e875da42f62cf8533e78435b7b24ca41ae0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: fix links to renamed network examplesVolker Hilsheimer2023-03-012-3/+3
| | | | | | | Change-Id: I8790bb660070a092e268294b5640c6d5af41deb0 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> (cherry picked from commit a02fb41c8ee039032045cbad02dd4f1dc3887d2f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: we no longer provide a list of common mnemonicsVolker Hilsheimer2023-03-011-5/+0
| | | | | | | | | | | | Remove the claim from the QKeySequence documentation, fixing the respective qdoc warning. Amends f10ae4b887f6652dcad95516ded43f2e2994e88f. Change-Id: If234cfb0a6b7dc20fb10e623cc3ee2ec167f22c9 Reviewed-by: Paul Wicking <paul.wicking@qt.io> (cherry picked from commit 1e50420354fc717b665cb8398658e97b89a7f953) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-17 16:23:00 +0000