summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* CMake: Update timestamp file for `Cross-Config` buildsv6.6.06.6.0Orkun Tokdemir2023-09-301-3/+17
| | | | | | | | | | | | | | | | | | Since https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8564 is merged, the timestamp file for {target}_json_file.txt should be updated for `Cross-Config` builds. The actual error message before this commit when CMake 3.28 is used: ``` ninja: error: 'src/corelib/Core_autogen/timestamp', needed by 'src/corelib/meta_types/Core_json_file_list.txt', missing and no known rule to make it ``` Change-Id: Ib544b18b67d2d4722f3801b1f46a0e0e18e59d48 Reviewed-by: Amir Masoud Abdol <amir.abdol@qt.io> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit 8041bfba47305352627d910930e52da496904c17) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 5c9e77298583d9955c139765783e403314799f42)
* QPointer: also provide a converting assignment operatorGiuseppe D'Angelo2023-09-252-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | d026fad3d962eed0119351cd37f34490e09153fd added converting constructors for QPointer. This however made converting _assignments_ ambiguous, introducing a regression for users coming from Qt < 6.6. This code: QPointer<Base> base; QPointer<Derived> derived; base = derived; used to convert `derived` to `Derived *` (using the implicit conversion operator from `QPointer<Derived>` to `Derived *`), and then the assignment operator for `QPointer<Base>` that took a `Base *`. The introduction of the conversion constructor in 6.6 makes it possible to convert `QPointer<Derived>` to `QPointer<Base>`, and then fall back to the compiler-generated assignment operator for `QPointer<Base>`. The result is that the code above is now ambiguous and stops compiling. Fix this by adding a converting assignment operator for QPointer. I'm only adding the const-lvalue overload because the implementation requires going through the private QWeakPointer::assign helper. We cannot copy-assign or move-assign the inner QWeakPointer, as those assignments require lock()ing the QWeakPointer and that's not possible on a QObject-tracking QWeakPointer (but cf. QTBUG-117483). Assigning from a rvalue QPointer would mean calling assign() on the internal QWeakPointer _and_ clear the incoming QPointer, and that's strictly worse than the lvalue overload (where we just call assign()). Change-Id: I33fb2a22b3d5110284d78e3d7c6cc79a5b73b67b Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit 6c504f2519e1180dbcfd77d5bb08b0db9742eeaa) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 11aa3b13b3edb3c8731ad45b8e475c6037ffce97) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* IPC: Move the legacy key to the QNativeIpcKeyThiago Macieira2023-09-226-27/+74
| | | | | | | | | | | | | | | | | | This is needed to support passing it to other processes so they can enable legacy, compatibility mode. Right now, there's no such code, but I am 90% certain we'll need it soon in 6.6.x, if not for compatibility changes in the future. There's a bug in passing a QNativeIpcKey to another process that causes QSharedMemory to use the wrong QSystemSemaphore for control (a feature that should never have existed in the first place, but we're 15 years too late on that). I have not yet investigated a fix for this, but it will likely involve knowing the original legacy key. Change-Id: Idd5e1bb52be047d7b4fffffd1750b547013cb336 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 9edb835904a7fa856e482464a7258019d5766333) (cherry picked from commit 271d38b0ef6d9e77f7e242bf3081e0571662ae1c)
* IPC: make the two platformSafeKey functions return QNativeIpcKeyThiago Macieira2023-09-224-45/+51
| | | | | | | | | | | | | | | | | | | There's no need to return QString, only to create the QNativeIpcKey elsewhere, when nothing uses this intermediary QString (those two functions aren't used in unit tests any more, since the two "IPC: add native key support" commits (2c286561bbc9e4e408d34e5bf43db8ad9acc0e84 and 3ae052d3bb5d7af0badf32575a5aa042cffd8243). Since they aren't used in the tests, we can remove the Q_AUTOTEST_EXPORT macro too and the unnecessary default argument. I'll need the ability to return QNativeIpcKey to store the original, legacy key inside of it. Change-Id: Idd5e1bb52be047d7b4fffffd17506c05e4f61f79 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit b5584ed2240abe3892fa5b0a23b3ad093ed9fec2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 608b08f4d57369378b1a101b78a46202bd17c11a)
* QItemSelectionModel: don't warn when destroying the modelVolker Hilsheimer2023-09-231-3/+3
| | | | | | | | | | | | | | | | | | | | | | Amends 4f4a8e75ab34003a4a49b89392ae7712415ac788, after which QItemSelectionModel printed a warning when destroying the model. We reset the selection model in response to the model getting destroyed, and since the model is already set to be nullptr at this point the select() function complains about changing the selection with no model set being a no-op. Fix this by not calling reset() when the model gets destroyed - the stored selection and currentIndex are already reset at this point - and instead only call reset() when a new model is set in initModel. Fixes: QTBUG-117200 Change-Id: I12fc6b3fb2f2ff2a34b46988d5f58151123f9976 Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> (cherry picked from commit dc126de22ea4d38736ae57c08c0b271f3c53fad9) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit ae8e356c5152cc62aef55edf50e41125c500cf44) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Switch QRgbaFloat api to hardcoded float parameter and return valuesv6.6.0-rc1Allan Sandfeld Jensen2023-09-211-13/+13
| | | | | | | | | | | | This makes it source compatible with Qt 6.5 by allowing us to change FastType to something other than float, which we have done for Qt 6.6 on systems with AVX float16 instructions. Change-Id: I7ebf0c178ba0ff7f04f6788d182a1a000fe31c0c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit baac34de6fcbdcc6ee5eb06c3db16c7eda32f121) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 224d4ad279ab37e99dc6194a2232e9f72ded6225)
* Upgrade Harfbuzz to version 8.2.0Eskil Abrahamsen Blomfeldt2023-09-2154-191/+1171
| | | | | | | | | Task-number: QTBUG-117136 Change-Id: I910c8bff2fe521aa02929b9000fa7f38192d1a51 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 08134e458d7fdd0b9565976046821b3903166dd6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 5a6d960018c1aac70c46ef1f9481b19ce01734df)
* Update public suffix listMarc Mutz2023-09-212-4158/+4192
| | | | | | | | | | | | | Version 1a4824549b093abc3077205ae5386ed57f73806d, fetched on 2023-09-20. Fixes: QTBUG-117138 Change-Id: If288d7fce714384a0132261303de31ad2299c239 Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io> Reviewed-by: Ievgenii Meshcheriakov <ievgenii.meshcheriakov@qt.io> (cherry picked from commit dee68587d5fd3feb99a04ad700f2cd065cf72797) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 99aa3d5ad1e6434edb8ef0a46975cef2fd62e4cb)
* [docs] Fix \since for qHash(qfloat16)Marc Mutz2023-09-201-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | The patch adding the function unexpectedly made it into 6.5 before 6.5.3 was forked off. That's nice, as it reduces the number of releases with a broken implementation, but the documentation and ChangeLog were written assuming a merge for 6.5.4. Fix the documentation. Amends 6da6a17de9ccfcd5458ea72507b131660e0ab948. [ChangeLog][Editorial][QtCore] Delete the old entry for qHash(qfloat16), keep the one from this commit. [ChangeLog][QtCore] Fixed qHash(qfloat16) which was broken from 6.5.0 to 6.5.2, inclusive. If you compiled against one of the affected Qt versions, you need to recompile against either Qt 6.4 or earlier or 6.5.3 or later, because the problematic code is inline. Task-number: QTBUG-116064 Task-number: QTBUG-116076 Change-Id: If8fa35fb8532cf0bbf2ba0438694d95fd9bd6991 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 0f19cafc3cbb85dfd67c5c6f7421943e9c063ea1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 8e14e13c16249f5dd4f25e8d681498e393241493)
* SQLite: Update SQLite to v3.43.1Andy Shaw2023-09-193-92/+101
| | | | | | | | | | | [ChangeLog][Third-Party Code] Updated SQLite to v3.43.1 Fixes: QTBUG-117139 Change-Id: Id4f7d55adb317f009613245510c4eb26678ddc7a Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 4583d808ea50beb8da9302f34eacfc1e9a2ed907) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 406ad89a3b97ab654b1ce833634eee167b954433)
* Sync rhi backingstore prefer-software env.var with QuickLaszlo Agocs2023-09-191-0/+5
| | | | | | | | | | | | | | | Behaving differently in QQuickWindow vs. a QRhi-based widget window is not great for WebEngine. The env.var naming is not the best (QSG prefix) but we already have some precedent for this (recognizing QSG_INFO in QRhi), and there is no other choice anyway. Task-number: QTBUG-116445 Change-Id: Ibfd495cbd1d42502441d6629325bdeb033e813f3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit ffb857e9d0745fdd31bca091333f1120c5857d7b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 69c0ca3174e2484a241dcfbeb786084eca3c57e5)
* Upgrade to Freetype 2.13.2Eskil Abrahamsen Blomfeldt2023-09-1937-3169/+320
| | | | | | | | | Task-number: QTBUG-117135 Change-Id: I2485cf286f590eccee9c4be4bb19559631288fd5 Reviewed-by: Christian Strømme <christian.stromme@qt.io> (cherry picked from commit 5641a5e1e54c9694a1ba1d462165db9c7c0e529c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit b2e888dc812762df9054e982929a894a1fab8a52)
* CMake: Fix condition of the ipc_posix featureJoerg Bornemann2023-09-181-1/+1
| | | | | | | | | | | | | | | | | | The ipc_posix feature was OFF despite the following test values: TEST_posix_shm ON TEST_posix_sem ON TEST_sysv_shm OFF TEST_sysv_sem OFF The 'NOT (TEST_sysv_shm AND TEST_sysv_sem)' part of the condition is not correctly evaluated. Resolve the parentheses to work around this issue. Fixes: QTBUG-117052 Change-Id: Idac23d207f8dd644d059977ca41b6e32b17b3a49 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit 828770c60c1c0342a015fc7fe2d6e714f645fb64) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 5c9fa4ca4a88a83c8fab84ce22f68af9c0a6a893)
* IPC: Remove the "small" object optimization in QNativeIpcKeyThiago Macieira2023-09-183-86/+47
| | | | | | | | | | | | | | | | | | The original design was supposed to be small, at a single pointer, but that never made it through, with the "QString key" member. So the anonymous union for typeAndFlags overlapping with the extension pointer was just unnecessary headache. So separate the two. This means QNativeIpcKey's size increases from 4 pointers to 40 bytes on 64-bit systems and to 24 bytes on 32-bit systems (so we have 6 unused bytes on both architectures). Fixes: QTBUG-116821 Change-Id: I512648fd617741199e67fffd1782b7d5ba5ddd12 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit eb5c5a76cf369dd5e40289c1013f043c7e82ff2e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit ef5f2322a767d84d31dc67d0be9a751054cf8b19)
* IPC: disallow unknown queries in QNativeIpcKey string formThiago Macieira2023-09-181-1/+2
| | | | | | | | | | | So we can add them in the future but cause older versions of Qt to reject them if they don't know what they are. Change-Id: I512648fd617741199e67fffd1782b85935bb832a Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit 18867845eb77537c4125e1da4dfcd049e303ee27) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit a5a1231d527a259d0dac9dc62e04a284fe183d51)
* Iterate over all extraPrefixDirs when collecting "directories"Alexey Edelev2023-09-181-5/+22
| | | | | | | | | | | | | | | | | | | When collecting plugins required for the android application according to linked targets we should take into account all prefix directories. But not only the first one. Otherwise the order we use when adding paths to extraPrefixDirs will affect collecting of the plugins. This specifically leads to the issue if the user project builds custom Qt plugins. The plugin directory from user project build tree will be found first and all plugins from Qt installation directory are discarded. Fixes: QTBUG-116920 Change-Id: Id94ebaf5ccd1a279a74b38b59ff535f45230e1b4 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit 630d3328ddc35a02c42fa6501636eaee6eb76a37) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 38f03c87193194dcb7aff1eb9c1fd63820839c0f)
* QtFuture: Prevent whenAll()/whenAny() from creating reference cyclesArno Rehn2023-09-181-6/+9
| | | | | | | | | | | | | | whenAll() and whenAny() create a shared context object which is referenced by the continuation lambda. The refcount of context is only correctly managed when it is copied non-const to the lambda's capture list. Fixes: QTBUG-116731 Change-Id: I8e79e1a0dc867f69bbacf1ed873f353a18f6ad38 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> (cherry picked from commit ba2ebc24a1b29020699dc2282b05a60506b56c6d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit a2792bac1a6077460f288a2b918449011f8c89d6)
* Fix crash when reading corrupt font dataEskil Abrahamsen Blomfeldt2023-09-151-16/+51
| | | | | | | | | | | | | | | | | | When loading the font data, we had some unprotected reads. To harden this, we check everything against the length of the font data before reading. [ChangeLog][QtGui][Windows] Fixed a possible crash that could happen when loading corrupted font data. Fixes: QTBUG-116773 Change-Id: I156df3b8833c9ed785fcc690821a7a74d9a51126 Reviewed-by: Lars Knoll <lars@knoll.priv.no> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit 9fe47cf2e11d7c9ad4f72e6fc5e53f10a9743b03) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit d0ed5db78160ce7c16d9fffef79aa11a7783e34e)
* Long live Q_(U)INT128_C()!Marc Mutz2023-09-152-8/+114
| | | | | | | | | | | | | | | | | | | Compilers that support 128-bit integer types usually don't have support for 128-bit literals, so provide Q_(U)INT128_C macros and back them with UDLs. This, of course, only works in C++, so until compilers provide built-in literals that support C, too, that's all we get. [ChangeLog][QtCore] Added Q_INT128_C() and Q_UINT128_C() macros to create qint128 and quint128 literals in a platform-independent way. Fixes: QTBUG-116822 Change-Id: I4be645baf2e007ee1aa1a27f9b5166671806dc49 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit 16433a4a6ed22750adfdb9633149c3bd485c4656) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 321dcd1d1d0fdd627160e882c471529baa6cafa7)
* Long live Q_(U)INT128_MIN/MAX!Marc Mutz2023-09-152-5/+61
| | | | | | | | | | | | | | | | Since compilers don't provide such macros, do it ourselves. In order to test these macros, add ad-hoc specializations of QTest::toString() for qint128 and quint128 locally to the test. Turns out it's not too hard to write them, so we might move them to a public header, yet. Change-Id: I1483f3af2ccec6038e1c780649f9ffe413bb59ef Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit 104a0a9ecdb18d65e4d9075d87e8860c6c9d8335) (cherry picked from commit 09bf722590ca6d1482b6605e1dffaaadd863e125) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Revamp Mandelbrot example: Revisit the documentatonRym Bouabid2023-09-151-2/+2
| | | | | | | | | | | | | | | | | Remove "Example" from the title. Edit the link (title) to the documentation of Mandelbrot in QThread documentation. Delete the foreach related sentence as we are trying to port away from this Qt pseudo-keyword. Task-number: QTBUG-108861 Change-Id: I6d04f24ac9c1fa1efe30a947c2da2ec7475edc80 Reviewed-by: Ivan Solovev <ivan.solovev@qt.io> (cherry picked from commit 73a1ae6ea91cbcc7ddfd80defd78ac924dea4c6e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit e9d400b4aae39519d11db95904800e0e36721188)
* Add some tests for q(u)int128Marc Mutz2023-09-141-0/+12
| | | | | | | | | | | | Check that QIntegerForSize<16> and std::numeric_limits<quint128> work and that q(u)int128 are available in C mode, too. Change-Id: I44af8282399c78f6e74a8268af53bad64407ca34 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit 32f66f7008ce8fff1a8cdc5219978d1a61d4684c) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 297aa6d751fbbb034f14eb376fcbbdca358cc593) Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
* Document q(u)int128 and QT_SUPPORTS_INT128Marc Mutz2023-09-141-0/+33
| | | | | | | | | | | | | | [ChangeLog][QtCore] Added qint128 and quint128 typedefs on platforms that support them. Fixes: QTBUG-116925 Change-Id: Ibd55cb0b1931b48a91598d3165e5911e3a4079f2 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit 454636afec1be8d4483b65ae564487eca9734ffd) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 66d10dc25369bfb03fb526ada97394b8af114039) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Mark feature API in QFont as preliminaryEskil Abrahamsen Blomfeldt2023-09-142-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | Using ints for the tags is not ideal. There is no type safe way to do conversions from strings, and how the int corresponds to the four-byte tag is not clear from the API, so user code can end up being less readable due to this. Especially since this type of tag is a data type used several places in fonts, and we will need them again for implementing support for variable axes, it's worth giving this an extra round of polish. Since it was not addressed in a timely manner and we don't want this to delay the upcoming release, we mark the API as preliminary for now, to give ourselves the option of changing it to something. Fixes: QTBUG-116929 Change-Id: I498478785dcd5ece954151f01f1a017828d6b8b8 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit 6ab362a7eaddd6b2e867c9de6dbb04b7f760d005) (cherry picked from commit 8055247fc0426d64e24d9d21a4ea5b984afa61fe) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QString: fix append() wrt. raw dataMårten Nordheim2023-09-131-1/+4
| | | | | | | | | | | | | | | | | | | | | | | When appending to an empty string, we optimize and copy the internal pointer. But if the other string was created with fromRawData this might be temporary data on the stack/heap and might be de-allocated or overwritten before the string is used or is forced to make a deep-copy. This would lead to incorrect data being used. This is easy to overlook if you plan to append multiple strings together, potentially supplied through an argument. Upon appending a second string it would make a full copy, but there might not be a guarantee for that. So, it's hard for users to avoid this pitfall! Fixes: QTBUG-115752 Change-Id: Ia9aa5f463121c2ce2e0e8eee8a6c8612b7297f2b Reviewed-by: Ahmad Samir <a.samirh78@gmail.com> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit 4660a230d527a9cffda41999103aba6ff5c2ecd5) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit d4a6c81081db24812a043c44d0d3d683b53e7d80) Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
* Fix qHash(qfloat16) to match Qt 6.4 behaviorMarc Mutz2023-09-122-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were two problems: - On platforms where QFLOAT16_IS_NATIVE == true, a qHash(qfloat16{}) call has become ambiguous between the three FP qHash() overloads (float, double, long double), where it was unambiguously calling the float one in Qt 6.4. This SiC was caused by the replacement of operator float() by operator __fp16() in 99c7f0419e66692260be56c0385badeacb3f6760, which is in Qt 6.5. - On platforms where QFLOAT16_IS_NATIVE == false, qHash(qfloat16{}) would produce a different value from qHash(float{}), and therefore Qt 6.4, when the seed was != 0, because the former would go via the one-arg-to-two-arg qHash adapter while the latter one would not. Since participating functions are inline, this causes old and new code to produce different hash values for the same qfloat16, leading to a BiC possibly corrupting QHash etc. Fix both by adding an explicit qHash(qfloat16). This function is inline, so it doesn't add a new symbol to 6.5.x. [ChangeLog][QtCore] Fixed qHash(qfloat16) which was broken from 6.5.0 to 6.5.3, inclusive. If you compiled against one of the affected Qt versions, you need to recompile against either Qt 6.4 or earlier or 6.5.4 or later, because the problematic code is inline. Pick-to: 6.5 Fixes: QTBUG-116064 Fixes: QTBUG-116076 Change-Id: Id02bc29a6c3ec463352f4bef314c040369081e9b Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit 6da6a17de9ccfcd5458ea72507b131660e0ab948) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Qt UDLs: avoid the deprecated form of UDL definitionsMarc Mutz2023-09-124-6/+6
| | | | | | | | | | | | | | | | cppreference.com says¹ that the space after the "" is deprecated now, so remove the space. Let's just hope all our compilers support this, otherwise it will get ugly². ¹ https://en.cppreference.com/w/cpp/language/user_literal#Literal_operators ² https://github.com/yhirose/cpp-httplib/issues/953 Pick-to: 6.5 6.2 Change-Id: Ic8e4939e3ba713023c5a5c020305c96b521dbda9 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit 5503b478935aee563d31c5df035803818f4cead3) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* syncqt: Add the missing is_open check to writeIfDifferentAlexey Edelev2023-09-121-0/+4
| | | | | | | | Pick-to: 6.5 Change-Id: I2a969483d20f250083c1a262bd3bfc696a7f0df4 Reviewed-by: Amir Masoud Abdol <amir.abdol@qt.io> (cherry picked from commit a86fb92d4bc1a64703cabf351035efc861ea54dd) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* syncqt: Mark updateOrCopy as exception freeAlexey Edelev2023-09-121-2/+3
| | | | | | | | | Pick-to: 6.5 Change-Id: I4ac468ef503775bca7d3848d26b42990bb4fdd1a Reviewed-by: Amir Masoud Abdol <amir.abdol@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit cab5ede6a3890b9cc07e54a0558a577c932ec21a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* syncqt: Handle possible exceptions thrown by std::filesystem::create_directoriesAlexey Edelev2023-09-121-7/+33
| | | | | | | | | | | Wrap the directory creation logic with try/catch to handle possible file system exceptions. Pick-to: 6.5 Change-Id: I11ad4552dccfdc8cc8a4ec4912d0a15d0f9557c6 Reviewed-by: Amir Masoud Abdol <amir.abdol@qt.io> (cherry picked from commit 7164cce881c3d65eb18749471ba5e358c7d5998a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* syncqt: Add the missing file stream close callsAlexey Edelev2023-09-121-0/+2
| | | | | | | | | | | Call close explicitly to avoid any issues related to non-closed file descriptors. Pick-to: 6.5 Change-Id: I02df30032dc04afd5d135d707eff4a6efe6a3ea5 Reviewed-by: Amir Masoud Abdol <amir.abdol@qt.io> (cherry picked from commit e9ca247479206b3d6f3815c599a244d9bfbae394) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* syncqt: Generate the deprecated header in the framework directory tooAlexey Edelev2023-09-121-2/+10
| | | | | | | | | | | | | Generate the missing deprecated header in the framework directory for the cross-module deprecation case. Amends 7e84a04563142d217317928865a8f6475d189d95 Pick-to: 6.5 Change-Id: Ibb2d262e41c6de7dfb34c39cabd6b19c43aa9636 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit 09c46d63af3ea68d7b49c395b9375d2b5d3ed666) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* xcb: Reflect geometry of foreign window on creationTor Arne Vestbø2023-09-122-2/+13
| | | | | | | Change-Id: I305b256696a32454f64c12c5a8901b65506fc520 Reviewed-by: Liang Qi <liang.qi@qt.io> (cherry picked from commit 4e2e3a6b4fe0ff5e1930707808f02e3be9343312) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Remove dead code in QMessageBoxAxel Spoerl2023-09-121-10/+0
| | | | | | | | | | Remove code guarded by #ifdef 0 Task-number: QTBUG-115832 Change-Id: I7d1dfd3dca2d8cda455d73f90dc2ae142ea41118 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> (cherry picked from commit b2f4e1e395bba4b72d5e1d5cc6e4469b97731a65) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* doc: Remove QSettings' paths for embedded linuxMohammadHossein Qanbari2023-09-121-6/+4
| | | | | | | | | | | Embedded Linux is just Linux nowadays. Fixes: QTBUG-116715 Change-Id: I1f64d27550db6f711c7f1f578e85cad12d0973aa Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Samuli Piippo <samuli.piippo@qt.io> (cherry picked from commit d8b7c03cc5b82276c74b6f210dc18a324ede3105) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QBindable: Add doc example for ctor taking property nameFabian Kosmale2023-09-121-1/+8
| | | | | | | Change-Id: I36de517291ef940d6fa284e062d44a5b619c0018 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit b7184e110434cdae127d03a1467ba6fb02607768) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* qobjectdefs.h - fix comment typoAxel Spoerl2023-09-121-1/+1
| | | | | | | Change-Id: I314c01156daaaf993ff0b80e049327d52e520382 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit 7c55651ff2537fdc9b7c8667aff38d98c0cd9b65) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QComboBox: scroll the popup to the top before positioning itRichard Moe Gustavsen2023-09-121-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the style changes while a popup is open (or about to close), the popup will change style as well before it's hidden. And this can result in the popup window briefly ending up smaller than what it needs to be, in order to fit all the menu items. In that case, it will show 'up' and 'down' widgets in the menu that auto scrolls it when hovered. And all this can happen for a split second while the menu is about to close (as a result of the user clicking on a menu item). A bug happens because of this if you click on the last menu item in the list, and this causes the style to change. In that case, the 'down' widget will end up directly underneath the mouse for a split second, which will trigger an auto-scroll timer to start. This timer will trigger a bit later, after the popup has been hidden, and scroll the list view a bit down. The result is that the next time you open the popup, it ends up at the wrong place on the screen in a failed attempt to center the current index on top of the combobox. This patch will make sure that we always scroll the list view to the top before we start calculating where the popup should be placed on the screen. Otherwise the geometry ends up wrong since the popup will anyway be resized (if possible) to fit all the menu items before it's shown and should therefore not take scrolling into account. Fixes: QTBUG-113765 Change-Id: I61b5b832904de471c2303fc67325feec322b1449 Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit 8393922e7071221a9c6c0811eb714f20bf4ed02b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Mention reset methods for QCalendarWidget::maximumDate, minimumDateKai Köhne2023-09-121-4/+6
| | | | | | | Change-Id: Ic3bfbcec1ac7d31ab704b52e6560d44f4a2054e7 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> (cherry picked from commit bd9a32adca32c6ad36e6c42c08eed3e62e9f3490) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QDialogButtonBox: Manage hide and show of standard buttonsAxel Spoerl2023-09-122-15/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0b421fa58b9a73d657bf17834788fd1175c4767e ensured a correct focus chain, when buttons in a QDialogButtonBox were hidden. The implementation did not check, if a hidden button was added via setStandardButtons(). In consequence, it was removed from the standardButtonHash and never added again. QDialogButtonBox::button() returned nullptr for a standard button, once it had been hidden. That introduced a regression. This follow-up patch makes sure, a standard button is not removed from standardButtonHash, when hidden. By no longer removing it from standardButtonHash, it makes showQDialogButtonBox::button() always return the pointer to the standard button, even if it is hidden. The function handleButtonDestroyed() used the argument QDialogButtonBoxPrivate::RemoveRule::KeepConnections, in order to leave signal/slot connections untouched. It expected the the destroyed button to be removed from standardButtonHash. In order to retain that functionality, the enum class RemoveRule is renamed to RemoveReason, and one value was added. QDialogButtonBoxPrivate now handles all necessary cases of removing a button: ManualRemove (previously Disconnect): - remove button from roles - remove button from standardButtonHash - disconnect all signals LeaveEvent (previously KeepConnections): - remove button from roles - do not remove button form standardButtonHash - do not disconnect signals Destroyed (new): - remove button from roles - remove button from standardButtonHash - do not disconnect signals (QObject will do that) An autotest is added to tst_QDialogButtonBox. Task-number: QTBUG-114377 Pick-to: 6.5 Change-Id: Ib28625d44fa89c3d06f181f64875c2e456cebbfa Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit edc984db384311e25a0afe4902585bd97e4ebcd1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* wasm: send key release for touchscreen inputLorn Potter2023-09-122-5/+8
| | | | | | | | | Fixes: QTBUG-114203 Change-Id: I117ce857484520167d0c0166280dd604c139ff03 Reviewed-by: Piotr Wierciński <piotr.wiercinski@qt.io> Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> (cherry picked from commit eda0ccb36baae10784f71552408148f095d25953) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Always run screen change side effectsMorten Sørvig2023-09-122-11/+13
| | | | | | | | | | | | | | | | | processWindowScreenChangedEvent() returns early if the screen for the (top-level) window has already been updated, for instance by a call to handleScreenRemoved(). This was preventing us from updating the DPR and window geometry. Move the code a slot connected to QWindow::screenChange, which gets emitted for all windows (also child windows), whenever the screen changes. Fixes: QTBUG-116232 Change-Id: I44701fd001ab1fd54efe9c8451c6a58cfc0b285f Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> (cherry picked from commit 89ce65c2d01e77c1cf49bb8579f63b60480e0186) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QProcess/Unix: update the close-file-descriptors feature with a minimumThiago Macieira2023-09-123-8/+18
| | | | | | | | | | | | | | | | | | | | | So that one can pass a few extra file descriptors to the child while still closing all the rest. strace -f of this test showed on Linux: [pid 117952] dup3(4, 0, 0) = 0 [pid 117952] dup3(9, 1, 0) = 1 [pid 117952] dup3(11, 2, 0) = 2 [pid 117952] close(12) = 0 [pid 117952] dup2(100, 3) = 3 [pid 117952] close_range(4, 2147483647, 0) = 0 [pid 117952] execve("testUnixProcessParameters/testUnixProcessParameters", ["testUnixProcessParameters/testUn"..., "file-descriptors2", "3", "100"], 0x561793dc87d0 /* 120 vars */ <unfinished ...> Change-Id: I3e3bfef633af4130a03afffd175e984bf50b558d Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> (cherry picked from commit abd2ffc1497e6d13a607362f7f4362e2a6d00448) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Doc: All overviews list categorizationJaishree Vyas2023-09-129-10/+9
| | | | | | | | | | | | | | The \generate list names are added for each categorized section with some explanation. Here, calling the overviews as explanations-(name of the section). The idea is to give general terms instead of specific phrases like 'core' etc, for better understanding. Task-number: QTBUG-115347 Pick-to: 6.5 Change-Id: I673e38c0e9193b7f7d54008bfcf82c2d3a10be3f Reviewed-by: Topi Reiniö <topi.reinio@qt.io> (cherry picked from commit 29eb5d8ace744cd4a946aca3f5f1ffe0f4bd0a1f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QAccessibleWidget: Remove pointless ZWSP in warning messageFabian Kosmale2023-09-121-1/+1
| | | | | | | | | | | | There doesn't seem to be reason for it to exist, and apparently it causes compilation failures with icc. Fixes: QTBUG-116517 Initial-patch-by: Yorick Bosman Change-Id: Ic2ed1d4318d522851278afa7f9791441af4fa709 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit ca4633f243a23de1848ebf32aef45f23d6d18154) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix backing store compositor transform with VulkanLaszlo Agocs2023-09-121-3/+4
| | | | | | | | | | | | | The problem does not become apparent until a QQuickWidget or QRhiWidget using Vulkan is put into a QScrollArea and then attempted to be scrolled vertically. Fixes: QTBUG-116338 Change-Id: I55367b51aaf2bb8d039bf5e313a0d8c3d7908327 Reviewed-by: Andy Nichols <andy.nichols@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit 750d00aba7e49b6093bc273924ba688cb433b505) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Require the C++17 standard for configure-time syncqtAlexey Edelev2023-09-121-1/+1
| | | | | | | | | | | | | Require the C++17 standard, but not what is set by Qt for syncqt, to avoid unwanted standard check in some corner cases. Pick-to: 6.5 Task-number: QTBUG-116789 Change-Id: I34e07e172e31d5ffc69b84dd3ef30f02f6e75a9d Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit 7a70c6fcfd5d3e000b80ab9b833f4e2b14a3563d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Rework QIcon theme documentationTor Arne Vestbø2023-09-121-55/+82
| | | | | | | | | | Generalized the documentation, and clarified behaviors, in preparation for adding additional platform icon engines. Change-Id: I4a694dc2cedd08cb195c738048c7dae72cbfe867 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 17dc1e2152c424343526962ce710cf4b2bbd920d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QWindow: avoid extra window resize on changing min/max sizesVladimir Belyavsky2023-09-121-1/+4
| | | | | | | | | | | | | | | Amends e7477e8934ab38722f5589914d08b3f15e870109. Do not call QWindow::resize() on changing min/max sizes if bounded window size has not changed. Otherwise it may unexpectedly reset window's state on some platforms, like Windows and Linux. Fixes: QTBUG-115699 Pick-to: 6.5 Change-Id: I217ca3fd854a1f41d6df312e3258734d1d3bce45 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 7efc0f6f1994a06359deb859fd73126d576df226) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update documentation for QPalette::accent APISanthosh Kumar2023-09-121-0/+8
| | | | | | | | | | | | | The documentation for QPalette::accent had been missed and its updated as part of this patchset. Amends patchset 17c589df94a2245ee92d45839c2cba73566d7310. Fixes: QTBUG-116930 Change-Id: Iaa53e15dbecaa3c741e2db013c96b4424be39e91 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> (cherry picked from commit e418980b2fbd60a778f469b0d6852aab28df9001) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-17 23:45:49 +0000