From 35cbf52f0c2efb14741fd624138cdeebee563a57 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 18 Aug 2022 11:10:09 +0200 Subject: Port QDir to qsizetype [1/3]: indexed to ranged loops MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Indexed for loops are prone to int/qsizetype mismatches, so use ranged for loops where possible. Pick-to: 6.4 6.3 6.2 Task-number: QTBUG-103525 Change-Id: Ia3e97a6b2924f92d3f7fb1a7ae075b59188006e9 Reviewed-by: Sona Kurazyan Reviewed-by: Mårten Nordheim --- src/corelib/io/qdir.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/corelib/io/qdir.cpp') diff --git a/src/corelib/io/qdir.cpp b/src/corelib/io/qdir.cpp index fa2746798ab..ee0871b57b4 100644 --- a/src/corelib/io/qdir.cpp +++ b/src/corelib/io/qdir.cpp @@ -285,8 +285,8 @@ inline void QDirPrivate::sortFileList(QDir::SortFlags sort, const QFileInfoList if (infos) *infos = l; if (names) { - for (int i = 0; i < n; ++i) - names->append(l.at(i).fileName()); + for (const QFileInfo &fi : l) + names->append(fi.fileName()); } } else { QScopedArrayPointer si(new QDirSortItem[n]); @@ -1057,8 +1057,8 @@ void QDir::setSearchPaths(const QString &prefix, const QStringList &searchPaths) return; } - for (int i = 0; i < prefix.length(); ++i) { - if (!prefix.at(i).isLetterOrNumber()) { + for (QChar ch : prefix) { + if (!ch.isLetterOrNumber()) { qWarning("QDir::setSearchPaths: Prefix can only contain letters or numbers"); return; } -- cgit v1.2.3