From 32efe589a39989d81e303219074958181ef44ff4 Mon Sep 17 00:00:00 2001 From: Denis Dzyubenko Date: Wed, 6 Jun 2012 11:43:26 +0200 Subject: Removed extra detach calls from QJsonArray::takeAt Change-Id: I5711ec6b03e3979eca61f62004a7c6f0eaae79e0 Reviewed-by: Lars Knoll --- src/corelib/json/qjsonarray.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'src/corelib/json/qjsonarray.cpp') diff --git a/src/corelib/json/qjsonarray.cpp b/src/corelib/json/qjsonarray.cpp index d5ca066012a..2fcb7a67e4f 100644 --- a/src/corelib/json/qjsonarray.cpp +++ b/src/corelib/json/qjsonarray.cpp @@ -377,13 +377,8 @@ QJsonValue QJsonArray::takeAt(int i) if (!a || i < 0 || i >= (int)a->length) return QJsonValue(QJsonValue::Undefined); - detach(); - QJsonValue v(d, a, a->at(i)); - v.detach(); - - removeAt(i); - + removeAt(i); // detaches return v; } -- cgit v1.2.3