From 9b67d89c24666d405dd00e63bb56c924738aa002 Mon Sep 17 00:00:00 2001
From: Konstantin Ritt <ritt.ks@gmail.com>
Date: Fri, 23 Jan 2015 13:05:12 +0400
Subject: Pass params of shareable type by const-ref rather than by value

...where passing them by value was not intentional.

Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
---
 src/tools/qdoc/htmlgenerator.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/tools/qdoc/htmlgenerator.cpp')

diff --git a/src/tools/qdoc/htmlgenerator.cpp b/src/tools/qdoc/htmlgenerator.cpp
index d422356822c..f4ada7132f9 100644
--- a/src/tools/qdoc/htmlgenerator.cpp
+++ b/src/tools/qdoc/htmlgenerator.cpp
@@ -3190,7 +3190,7 @@ void HtmlGenerator::generateList(const Node* relative, CodeMarker* marker, const
 
 #if 0
     QStringList keys = groups.uniqueKeys();
-    foreach (QString key, keys) {
+    foreach (const QString &key, keys) {
         GroupNode* gn = static_cast<GroupNode*>(groups.value(key));
         if (gn) {
             out() << QString("<h3><a href=\"%1\">%2</a></h3>\n").arg(
@@ -3217,7 +3217,7 @@ void HtmlGenerator::generateList(const Node* relative, CodeMarker* marker, const
 
             out() << "<ul>\n";
             QStringList titles = nm.keys();
-            foreach (QString t, titles) {
+            foreach (const QString &t, titles) {
                 Node* member = nm.value(t);
                 QString title = member->fullTitle();
                 if (title.startsWith("The "))
@@ -4484,7 +4484,7 @@ void HtmlGenerator::generateManifestFiles()
   for each manifest file to be generated. \a manifest is the
   type of manifest file.
  */
-void HtmlGenerator::generateManifestFile(QString manifest, QString element)
+void HtmlGenerator::generateManifestFile(const QString &manifest, const QString &element)
 {
     ExampleNodeMap& exampleNodeMap = qdb_->exampleNodeMap();
     if (exampleNodeMap.isEmpty())
-- 
cgit v1.2.3