From 2422251ee5025a067b14b989153764ab36e43f10 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Sat, 20 Jun 2015 12:58:10 +0200 Subject: qdoc: don't hold QQmlJS::AST::SourceLocation in QLists QQmlJS::AST::SourceLocation wasn't marked as movable, and it is larger than void*, so QList is horribly inefficient. Fix by marking as movable primitive and holding in QVector instead. The same fix probably is required in QtDeclarative, too. Change-Id: I4e0d2cd32b7e03205d59cbc9900287f77045154a Reviewed-by: Martin Smith --- src/tools/qdoc/qmlparser/qqmljsengine_p.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/tools/qdoc/qmlparser/qqmljsengine_p.cpp') diff --git a/src/tools/qdoc/qmlparser/qqmljsengine_p.cpp b/src/tools/qdoc/qmlparser/qqmljsengine_p.cpp index 4e130517304..2a949b630c6 100644 --- a/src/tools/qdoc/qmlparser/qqmljsengine_p.cpp +++ b/src/tools/qdoc/qmlparser/qqmljsengine_p.cpp @@ -125,7 +125,7 @@ void Engine::setCode(const QString &code) void Engine::addComment(int pos, int len, int line, int col) { if (len > 0) _comments.append(QQmlJS::AST::SourceLocation(pos, len, line, col)); } -QList Engine::comments() const +QVector Engine::comments() const { return _comments; } Lexer *Engine::lexer() const -- cgit v1.2.3