diff options
| author | Mitch Curtis <mitch.curtis@qt.io> | 2024-07-30 10:39:03 +0800 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2024-09-12 20:22:42 +0000 |
| commit | 9adf7f2846801dd33511c683c19978553f56c1d4 (patch) | |
| tree | 98ac3cb773b49f8b696a3d726253b85c17160ce0 /src/quicktestutils/quick/visualtestutils.cpp | |
| parent | 0f7d896af4e2f8ef95d8d47b2de229ad9d9189be (diff) | |
QQuickVisualTestUtils::compareImages: actually check all colors
The function was added in 906d5c5c40183468f9521277c6244a6c46730de6. The
tests there don't only use red, so it looks like this bug has existed
since 2013.
Change-Id: I4bdf87fe6be0224016baf9a2a80faee6fe61514e
Reviewed-by: JiDe Zhang <zhangjide@uniontech.com>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 74c019e799fab74b85cd444c1e104638b7dd6c96)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 1eaef559a616ff9b2acb86f82c154e57b9f75168)
(cherry picked from commit c258f31173a020e9736132f7deb15eb2d5725f0e)
Diffstat (limited to 'src/quicktestutils/quick/visualtestutils.cpp')
| -rw-r--r-- | src/quicktestutils/quick/visualtestutils.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/quicktestutils/quick/visualtestutils.cpp b/src/quicktestutils/quick/visualtestutils.cpp index 6237dc1c9b..a36379aa63 100644 --- a/src/quicktestutils/quick/visualtestutils.cpp +++ b/src/quicktestutils/quick/visualtestutils.cpp @@ -159,8 +159,8 @@ bool QQuickVisualTestUtils::compareImages(const QImage &ia, const QImage &ib, QS // No tolerance for error in the alpha. if ((a & 0xff000000) != (b & 0xff000000) || qAbs(qRed(a) - qRed(b)) > tolerance - || qAbs(qRed(a) - qRed(b)) > tolerance - || qAbs(qRed(a) - qRed(b)) > tolerance) { + || qAbs(qGreen(a) - qGreen(b)) > tolerance + || qAbs(qBlue(a) - qBlue(b)) > tolerance) { QDebug(errorMessage) << "Mismatch at:" << x << y << ':' << Qt::hex << Qt::showbase << a << b; return false; |