From 7ed99f7879852d032f7dd4eeb520cdafc1dbae0b Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Mon, 26 Aug 2024 11:33:33 +0200 Subject: QmlCompiler: Fix various coverity warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Pass values by const ref or move them, but don't pass them as copies. Coverity-Id: 467911 Coverity-Id: 467912 Coverity-Id: 467913 Coverity-Id: 467914 Coverity-Id: 467915 Coverity-Id: 467916 Coverity-Id: 467917 Coverity-Id: 467918 Coverity-Id: 467919 Coverity-Id: 467920 Coverity-Id: 467921 Coverity-Id: 467922 Coverity-Id: 467923 Coverity-Id: 467924 Coverity-Id: 467925 Coverity-Id: 467926 Coverity-Id: 467927 Coverity-Id: 467928 Change-Id: I1549e1f3365c6becc330603959a71b2058e1b1fa Reviewed-by: Olivier De Cannière Reviewed-by: Fabian Kosmale --- src/qmlcompiler/qqmljsfunctioninitializer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/qmlcompiler/qqmljsfunctioninitializer.cpp') diff --git a/src/qmlcompiler/qqmljsfunctioninitializer.cpp b/src/qmlcompiler/qqmljsfunctioninitializer.cpp index 5d0b32a5af..c486ac273b 100644 --- a/src/qmlcompiler/qqmljsfunctioninitializer.cpp +++ b/src/qmlcompiler/qqmljsfunctioninitializer.cpp @@ -254,7 +254,7 @@ QQmlJSCompilePass::Function QQmlJSFunctionInitializer::run( QString name = u"binding for "_s; // #### ast = new (&pool) QQmlJS::AST::FunctionDeclaration( - pool.newString(name), /*formals*/ nullptr, body); + pool.newString(std::move(name)), /*formals*/ nullptr, body); ast->lbraceToken = astNode->firstSourceLocation(); ast->functionToken = ast->lbraceToken; ast->rbraceToken = astNode->lastSourceLocation(); -- cgit v1.2.3