From b4ed50f0090c3cec8e74b99b3a35c6266e6dc2ec Mon Sep 17 00:00:00 2001 From: Juha Vuolle Date: Mon, 7 Apr 2025 16:11:28 +0300 Subject: Fix compilation when draganddrop support is disabled When Qt is configured with -no-feature-draganddrop, the quick_draganddrop feature gets disabled too. Consequently many dialog files are then omitted from the build, see src/quickdialogs/quickdialogsquickimpl/CMakeLists.txt. As a result, some dialogs and templates that include and use these files/classes unconditionally, fail to compile. This commit adds same feature guards to these includes/uses. In addition this commit adds the few missing 'drag' feature guards in QQuickVerticalHeaderView as well as adds appropriate feature guards to autotests. Pick-to: 6.9 6.8 Fixes: QTBUG-135740 Change-Id: If1688a3cd8f52918088a8c586d54ccf09cb08890 Reviewed-by: Oliver Eftevaag --- src/quickcontrolstestutils/dialogstestutils.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/quickcontrolstestutils/dialogstestutils.cpp') diff --git a/src/quickcontrolstestutils/dialogstestutils.cpp b/src/quickcontrolstestutils/dialogstestutils.cpp index 2b21f674d1..ed30d6f76b 100644 --- a/src/quickcontrolstestutils/dialogstestutils.cpp +++ b/src/quickcontrolstestutils/dialogstestutils.cpp @@ -13,7 +13,7 @@ #include #include #include -#if QT_CONFIG(quick_listview) +#if QT_CONFIG(quick_listview) && QT_CONFIG(draganddrop) #include #include #include @@ -21,7 +21,7 @@ QT_BEGIN_NAMESPACE -#if QT_CONFIG(quick_listview) +#if QT_CONFIG(quick_listview) && QT_CONFIG(draganddrop) bool QQuickDialogTestUtils::verifyFileDialogDelegates(QQuickListView *fileDialogListView, const QStringList &expectedFiles, QString &failureMessage) { @@ -111,7 +111,7 @@ bool QQuickDialogTestUtils::verifyBreadcrumbDelegates(QQuickFolderBreadcrumbBar return true; } -#endif +#endif // QT_CONFIG(quick_listview) && QT_CONFIG(draganddrop) QQuickAbstractButton *QQuickDialogTestUtils::findDialogButton(QQuickDialogButtonBox *box, const QString &buttonText) { -- cgit v1.2.3