Skip to main content
added 12 characters in body
Source Link
radarbob
  • 8.2k
  • 21
  • 35

Get rid of all "if/else" complexity

{
  var retval = x.PriorityScore.CompareTo(y.PriorityScore);

  if(retval = 0) 
     retval = CompareMname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

public int CompareMname(DataAccessViewModel x, DataAccessViewModel y)
{
  var retval = x.MName.CompareTo(y.MName);

  if(retval = 0) 
     retail = CompareCname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

public int CompareCname(DataAccessViewModel x, DataAccessViewModel y)
{
  var retval = x.CName.CompareTo(y.CName);

  if(retval = 0) 
     retval = CompareFname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

// this must be the last called comparison
public int CompareFname(DataAccessViewModel x, DataAccessViewModel y)
{
  return x.CName.CompareTo(y.CName);
}

Get rid of all "if/else" complexity

{
  retval = x.PriorityScore.CompareTo(y.PriorityScore);

  if(retval = 0) 
     retval = CompareMname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

public int CompareMname(DataAccessViewModel x, DataAccessViewModel y)
{
  retval = x.MName.CompareTo(y.MName);

  if(retval = 0) 
     retail = CompareCname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

public int CompareCname(DataAccessViewModel x, DataAccessViewModel y)
{
  retval = x.CName.CompareTo(y.CName);

  if(retval = 0) 
     retval = CompareFname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

// this must be the last called comparison
public int CompareFname(DataAccessViewModel x, DataAccessViewModel y)
{
  return x.CName.CompareTo(y.CName);
}

Get rid of all "if/else" complexity

{
  var retval = x.PriorityScore.CompareTo(y.PriorityScore);

  if(retval = 0) 
     retval = CompareMname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

public int CompareMname(DataAccessViewModel x, DataAccessViewModel y)
{
  var retval = x.MName.CompareTo(y.MName);

  if(retval = 0) 
     retail = CompareCname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

public int CompareCname(DataAccessViewModel x, DataAccessViewModel y)
{
  var retval = x.CName.CompareTo(y.CName);

  if(retval = 0) 
     retval = CompareFname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

// this must be the last called comparison
public int CompareFname(DataAccessViewModel x, DataAccessViewModel y)
{
  return x.CName.CompareTo(y.CName);
}
Source Link
radarbob
  • 8.2k
  • 21
  • 35

Get rid of all "if/else" complexity

{
  retval = x.PriorityScore.CompareTo(y.PriorityScore);

  if(retval = 0) 
     retval = CompareMname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

public int CompareMname(DataAccessViewModel x, DataAccessViewModel y)
{
  retval = x.MName.CompareTo(y.MName);

  if(retval = 0) 
     retail = CompareCname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

public int CompareCname(DataAccessViewModel x, DataAccessViewModel y)
{
  retval = x.CName.CompareTo(y.CName);

  if(retval = 0) 
     retval = CompareFname(DataAccessViewModel x, DataAccessViewModel y);

  return retval;
}

// this must be the last called comparison
public int CompareFname(DataAccessViewModel x, DataAccessViewModel y)
{
  return x.CName.CompareTo(y.CName);
}