Return to Answer

Also, wazzup with that trailing _ underscore? Typically we follow that convention for local variables like dir_ or map_, when we don't want to shadow a builtin. That's not what happening here. Plus, the identifier is part of your Public API, so spelling matters, more than for a local variable.

Also, wazzup with that trailing _ underscore? Typically we follow that convention for local variables like dir_ or map_, when we want to avoid shadowing a builtin. That's not what happening here. Plus, the identifier is part of your Public API, so spelling matters, more than for a local variable.

Similarly for _param_ and _returns_, but they additionally have redundant type annotations, which I fear can get out of sync with the signature's annotations. Recommend you specify type in just one place: the function signature.

Similarly for _param_ and _returns_, but they additionally have redundant type annotations, which I fear can get out of sync with the signature's annotations. Recommend you specify type in just one place: the function signature. That way the mypy linter (type checker) can offer you automated assistance.

Messing around with upper M vs lower m in Makefile is not well-motivated here (no explanatory comment) and is likely to lead to bugs.