Skip to main content
added 118 characters in body
Source Link
janos
  • 113.1k
  • 15
  • 154
  • 396

Try this approach: instead of using an if condition with many terms OR-ed together, which is hard to read and error prone, use a loop.

Try this approach:

Try this approach: instead of using an if condition with many terms OR-ed together, which is hard to read and error prone, use a loop.

deleted 1 character in body
Source Link
$sources = [
    [
        'url'  => 'http://mysite.me/library/sections/2/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/5/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/7/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/9/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/10/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/11/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/13/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/3/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Directory'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/8/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Directory'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/2/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/5/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/7/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/9/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/10/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/11/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/13/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ]
];

$exists = false;
foreach ($sources as $source) {
    $xml = simplexml_load_file($source['url']);

    if (isset($xml->{$source['node']}) && $xml->{$source['node']} != '')) {
        $exists = true;
        break;
    }
}

if ($exists) {
    echo 'Exists';
} else {
    echo 'New';
}
$sources = [
    [
        'url'  => 'http://mysite.me/library/sections/2/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/5/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/7/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/9/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/10/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/11/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/13/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/3/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Directory'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/8/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Directory'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/2/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/5/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/7/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/9/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/10/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/11/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/13/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ]
];

$exists = false;
foreach ($sources as $source) {
    $xml = simplexml_load_file($source['url']);

    if (isset($xml->{$source['node']}) && $xml->{$source['node']} != '')) {
        $exists = true;
        break;
    }
}

if ($exists) {
    echo 'Exists';
} else {
    echo 'New';
}
$sources = [
    [
        'url'  => 'http://mysite.me/library/sections/2/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/5/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/7/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/9/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/10/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/11/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/13/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/3/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Directory'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/8/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Directory'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/2/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/5/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/7/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/9/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/10/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/11/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/13/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ]
];

$exists = false;
foreach ($sources as $source) {
    $xml = simplexml_load_file($source['url']);

    if (isset($xml->{$source['node']}) && $xml->{$source['node']} != '') {
        $exists = true;
        break;
    }
}

if ($exists) {
    echo 'Exists';
} else {
    echo 'New';
}
Source Link

Try this approach:

$sources = [
    [
        'url'  => 'http://mysite.me/library/sections/2/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/5/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/7/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/9/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/10/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/11/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/13/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/3/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Directory'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/8/all?title=' . $movie->title() . '&HndJk7Sd',
        'node' => 'Directory'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/2/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/5/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/7/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/9/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/10/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/11/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ],
    [
        'url'  => 'http://mysite.me/library/sections/13/all?guid=movieid' . $movieid . '%3Flang%3Dnl&HndJk7Sd',
        'node' => 'Video'
    ]
];

$exists = false;
foreach ($sources as $source) {
    $xml = simplexml_load_file($source['url']);

    if (isset($xml->{$source['node']}) && $xml->{$source['node']} != '')) {
        $exists = true;
        break;
    }
}

if ($exists) {
    echo 'Exists';
} else {
    echo 'New';
}