diff options
| author | Taylor Blau <me@ttaylorr.com> | 2022-05-24 14:54:27 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-05-24 14:27:19 -0700 |
| commit | 58a6abb7bae98357677657825631de6652256be9 (patch) | |
| tree | 7c139860a173394cb6d2eec7d893b143a684d17e /builtin | |
| parent | 44f9fd649673362bdbaae7067a9919b1fe4c96d1 (diff) | |
| download | git-58a6abb7bae98357677657825631de6652256be9.tar.gz | |
builtin/pack-objects.c: avoid redundant NULL check
Before calling `for_each_object_in_pack()`, the caller
`read_packs_list_from_stdin()` loops through each of the `include_packs`
and checks that its `->util` pointer (which is used to store the `struct
packed_git *` itself) is non-NULL.
This check is redundant, because `read_packs_list_from_stdin()` already
checks that the included packs are non-NULL earlier on in the same
function (and it does not add any new entries in between).
Remove this check, since it is not doing anything in the meantime.
Co-authored-by: Victoria Dye <vdye@github.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/pack-objects.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index ba2006f221..f5b098a2d4 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -3361,8 +3361,6 @@ static void read_packs_list_from_stdin(void) for_each_string_list_item(item, &include_packs) { struct packed_git *p = item->util; - if (!p) - die(_("could not find pack '%s'"), item->string); for_each_object_in_pack(p, add_object_entry_from_pack, &revs, |