diff options
| author | Junio C Hamano <gitster@pobox.com> | 2024-07-17 10:47:26 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-07-17 10:47:26 -0700 |
| commit | e13feda98f59cd34d8efce69b3db0cb16c4d3c3b (patch) | |
| tree | 1390777130994835724cfb3a5332a517a09f5bce /t/t5529-push-errors.sh | |
| parent | dd6d10285b91af584d0f9316467d870fa3d20c1d (diff) | |
| parent | 757c6ee7a3f6e1266bba0bf47545471c027c8340 (diff) | |
| download | git-e13feda98f59cd34d8efce69b3db0cb16c4d3c3b.tar.gz | |
Merge branch 'kn/push-empty-fix'
"git push '' HEAD:there" used to hit a BUG(); it has been corrected
to die with "fatal: bad repository ''".
* kn/push-empty-fix:
builtin/push: call set_refspecs after validating remote
Diffstat (limited to 't/t5529-push-errors.sh')
| -rwxr-xr-x | t/t5529-push-errors.sh | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/t/t5529-push-errors.sh b/t/t5529-push-errors.sh index 0247137cb3..17d7257892 100755 --- a/t/t5529-push-errors.sh +++ b/t/t5529-push-errors.sh @@ -2,6 +2,9 @@ test_description='detect some push errors early (before contacting remote)' +GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main +export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME + TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh @@ -38,6 +41,20 @@ test_expect_success 'detect missing sha1 expressions early' ' test_cmp expect rp-ran ' +# We use an existing local_ref, since it follows a different flow in +# 'builtin/push.c:set_refspecs()' and we want to test that regression. +test_expect_success 'detect empty remote with existing local ref' ' + test_must_fail git push "" main 2> stderr && + grep "fatal: bad repository ${SQ}${SQ}" stderr +' + +# While similar to the previous test, here we want to ensure that +# even targeted refspecs are handled. +test_expect_success 'detect empty remote with targeted refspec' ' + test_must_fail git push "" HEAD:refs/heads/main 2> stderr && + grep "fatal: bad repository ${SQ}${SQ}" stderr +' + test_expect_success 'detect ambiguous refs early' ' git branch foo && git tag foo && |