From ec9b74b18e019a8adff827ab22380f9771ac5f00 Mon Sep 17 00:00:00 2001 From: Rubén Justo Date: Tue, 23 Apr 2024 00:54:14 +0200 Subject: add-patch: plug a leak handling the '/' command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Plug a leak we have since d6cf873340 (built-in add -p: implement the '/' ("search regex") command, 2019-12-13). This leak can be triggered with: $ printf "A\n\nB\n" >file $ git add file && git commit -m file $ printf "AA\n\nBB\n" >file $ printf "s\n/ .\n" >lines $ git add -p Signed-off-by: Junio C Hamano --- add-patch.c | 1 + 1 file changed, 1 insertion(+) (limited to 'add-patch.c') diff --git a/add-patch.c b/add-patch.c index a06dd18985..0997d4af73 100644 --- a/add-patch.c +++ b/add-patch.c @@ -1646,6 +1646,7 @@ static int patch_update_file(struct add_p_state *s, err(s, _("No hunk matches the given pattern")); break; } + regfree(®ex); hunk_index = i; } else if (s->answer.buf[0] == 's') { size_t splittable_into = hunk->splittable_into; -- cgit 1.2.3-korg