From 63e14ee2d69b58eae72e34df81f2cde145427037 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 19 Aug 2022 06:08:32 -0400 Subject: refs: mark unused each_ref_fn parameters Functions used with for_each_ref(), etc, need to conform to the each_ref_fn interface. But most of them don't need every parameter; let's annotate the unused ones to quiet -Wunused-parameter. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- fetch-pack.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'fetch-pack.c') diff --git a/fetch-pack.c b/fetch-pack.c index d35be4177b..bda9d0f433 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -176,8 +176,10 @@ static int rev_list_insert_ref(struct fetch_negotiator *negotiator, return 0; } -static int rev_list_insert_ref_oid(const char *refname, const struct object_id *oid, - int flag, void *cb_data) +static int rev_list_insert_ref_oid(const char *UNUSED(refname), + const struct object_id *oid, + int UNUSED(flag), + void *cb_data) { return rev_list_insert_ref(cb_data, oid); } @@ -580,8 +582,10 @@ static int mark_complete(const struct object_id *oid) return 0; } -static int mark_complete_oid(const char *refname, const struct object_id *oid, - int flag, void *cb_data) +static int mark_complete_oid(const char *UNUSED(refname), + const struct object_id *oid, + int UNUSED(flag), + void *UNUSED(cb_data)) { return mark_complete(oid); } -- cgit 1.2.3-korg From e5e056b21dc5c128b5349ac336c6315943e88dee Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 19 Aug 2022 06:08:52 -0400 Subject: run-command: mark unused async callback parameters The start_async(), etc, functions need a "proc" callback that conforms to a particular interface. Not every callback needs every parameter (e.g., the caller might not even ask to open an input descriptor, in which case there is no point in the callback looking at it). Let's mark these for -Wunused-parameter. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- builtin/receive-pack.c | 2 +- convert.c | 2 +- fetch-pack.c | 2 +- send-pack.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'fetch-pack.c') diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index afd36c9c53..6882d526e6 100644 --- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c @@ -465,7 +465,7 @@ static void rp_error(const char *err, ...) va_end(params); } -static int copy_to_sideband(int in, int out, void *arg) +static int copy_to_sideband(int in, int UNUSED(out), void *UNUSED(arg)) { char data[128]; int keepalive_active = 0; diff --git a/convert.c b/convert.c index b31a25b536..25d89fa83b 100644 --- a/convert.c +++ b/convert.c @@ -619,7 +619,7 @@ struct filter_params { const char *path; }; -static int filter_buffer_or_fd(int in, int out, void *data) +static int filter_buffer_or_fd(int UNUSED(in), int out, void *data) { /* * Spawn cmd and feed the buffer contents through its stdin. diff --git a/fetch-pack.c b/fetch-pack.c index bda9d0f433..9f2933e868 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -823,7 +823,7 @@ static int everything_local(struct fetch_pack_args *args, return retval; } -static int sideband_demux(int in, int out, void *data) +static int sideband_demux(int UNUSED(in), int out, void *data) { int *xd = data; int ret; diff --git a/send-pack.c b/send-pack.c index 662f7c2aeb..7e99c64e6b 100644 --- a/send-pack.c +++ b/send-pack.c @@ -266,7 +266,7 @@ static int receive_status(struct packet_reader *reader, struct ref *refs) return ret; } -static int sideband_demux(int in, int out, void *data) +static int sideband_demux(int UNUSED(in), int out, void *data) { int *fd = data, ret; if (async_with_fork()) -- cgit 1.2.3-korg