From eea0e59ffbed6e33d171ace5be13cde9faa41639 Mon Sep 17 00:00:00 2001 From: Elijah Newren Date: Sat, 23 Dec 2023 17:14:50 +0000 Subject: treewide: remove unnecessary includes in source files Each of these were checked with gcc -E -I. ${SOURCE_FILE} | grep ${HEADER_FILE} to ensure that removing the direct inclusion of the header actually resulted in that header no longer being included at all (i.e. that no other header pulled it in transitively). ...except for a few cases where we verified that although the header was brought in transitively, nothing from it was directly used in that source file. These cases were: * builtin/credential-cache.c * builtin/pull.c * builtin/send-pack.c Signed-off-by: Elijah Newren Signed-off-by: Junio C Hamano --- http-push.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'http-push.c') diff --git a/http-push.c b/http-push.c index a704f490fd..329513270c 100644 --- a/http-push.c +++ b/http-push.c @@ -6,10 +6,8 @@ #include "tag.h" #include "blob.h" #include "http.h" -#include "refs.h" #include "diff.h" #include "revision.h" -#include "exec-cmd.h" #include "remote.h" #include "list-objects.h" #include "setup.h" -- cgit 1.2.3-korg From f25e65e0fea5cc45559079d9a84386efe2eb0c0c Mon Sep 17 00:00:00 2001 From: Elijah Newren Date: Sat, 23 Dec 2023 17:14:54 +0000 Subject: http.h: remove unnecessary include The unnecessary include in the header transitively pulled in some other headers actually needed by source files, though. Have those source files explicitly include the headers they need. Signed-off-by: Elijah Newren Signed-off-by: Junio C Hamano --- http-fetch.c | 1 + http-push.c | 1 + http.h | 1 - remote-curl.c | 1 + 4 files changed, 3 insertions(+), 1 deletion(-) (limited to 'http-push.c') diff --git a/http-fetch.c b/http-fetch.c index 93695a440a..bec94988bb 100644 --- a/http-fetch.c +++ b/http-fetch.c @@ -6,6 +6,7 @@ #include "walker.h" #include "setup.h" #include "strvec.h" +#include "url.h" #include "urlmatch.h" #include "trace2.h" diff --git a/http-push.c b/http-push.c index 329513270c..b4d0b2a6aa 100644 --- a/http-push.c +++ b/http-push.c @@ -15,6 +15,7 @@ #include "strvec.h" #include "tree.h" #include "tree-walk.h" +#include "url.h" #include "packfile.h" #include "object-store-ll.h" #include "commit-reach.h" diff --git a/http.h b/http.h index 3a409bccd4..3af19a8bf5 100644 --- a/http.h +++ b/http.h @@ -10,7 +10,6 @@ struct packed_git; #include "strbuf.h" #include "remote.h" -#include "url.h" #define DEFAULT_MAX_REQUESTS 5 diff --git a/remote-curl.c b/remote-curl.c index 204feebabe..55eefa70f9 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -21,6 +21,7 @@ #include "quote.h" #include "trace2.h" #include "transport.h" +#include "url.h" #include "write-or-die.h" static struct remote *remote; -- cgit 1.2.3-korg