From ce68178a0ae222b71fe5f89f05dc7113267c079b Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Sat, 13 Jul 2024 21:08:19 +0000 Subject: strvec: declare the `strvec_push_nodup()` function globally This function differs from `strvec_push()` in that it takes ownership of the allocated string that is passed as second argument. This is useful when appending elements to the string array that have been freshly allocated and serve no further other purpose after that. Without declaring this function globally, call sites would allocate the memory, only to have `strvec_push()` duplicate the string, and then the first copy would need to be released. Having this function globally avoids that kind of unnecessary work. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- strvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'strvec.c') diff --git a/strvec.c b/strvec.c index d4073ec9fa..f712070f57 100644 --- a/strvec.c +++ b/strvec.c @@ -10,7 +10,7 @@ void strvec_init(struct strvec *array) memcpy(array, &blank, sizeof(*array)); } -static void strvec_push_nodup(struct strvec *array, const char *value) +void strvec_push_nodup(struct strvec *array, char *value) { if (array->v == empty_strvec) array->v = NULL; -- cgit 1.2.3-korg