From 6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c Mon Sep 17 00:00:00 2001 From: Arnout Engelen Date: Sat, 18 Dec 2010 22:28:00 +0100 Subject: Improve error messages when temporary file creation fails Before, when creating a temporary file failed, a generic 'Unable to create temporary file' message was printed. In some cases this could lead to confusion as to which directory should be checked for correct permissions etc. This patch adds the template for the temporary filename to the error message, converting it to an absolute path if needed. A test verifies that the template is indeed printed when pointing to a nonexistent or unwritable directory. A copy of the original template is made in case mkstemp clears the template. Signed-off-by: Arnout Engelen Signed-off-by: Junio C Hamano --- test-mktemp.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 test-mktemp.c (limited to 'test-mktemp.c') diff --git a/test-mktemp.c b/test-mktemp.c new file mode 100644 index 0000000000..c8c54213a3 --- /dev/null +++ b/test-mktemp.c @@ -0,0 +1,14 @@ +/* + * test-mktemp.c: code to exercise the creation of temporary files + */ +#include "git-compat-util.h" + +int main(int argc, char *argv[]) +{ + if (argc != 2) + usage("Expected 1 parameter defining the temporary file template"); + + xmkstemp(xstrdup(argv[1])); + + return 0; +} -- cgit 1.2.3-korg