-
Notifications
You must be signed in to change notification settings - Fork 24
Release/0.1.0 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.1.0 #106
Conversation
The CoC file in the repo was removed in favor of inheriting the one from WordPress/.github
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Noting I bumped the WP minimum to 6.9 so the related test will fail there now until Tuesday when the release ships, but we need that minimum for the plugin on WPORG. |
ai.php
Outdated
| * Description: AI experiments and capabilities for WordPress. | ||
| * Version: 0.1.0 | ||
| * Requires at least: 6.8 | ||
| * Requires at least: 6.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the reason for requiring 6.9 because of the Abilities API that ships there? We are bundling that right now in this plugin so things work fine on 6.8 (or presumably older versions). I'm fine with this at 6.9 but curious if there's a specific reason for enforcing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose I assumed we were relying on the core-bundled Abilities, so if that's not the case then yeah we can probably drop this back down to 6.8 and perhaps come back to discussing how we want to handle Abilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good question. Personally, I'd rather depend on 6.9 and not bundle the Abilities API. I don't think the extra complexity is worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 838649c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd rather depend on 6.9 and not bundle the Abilities API. I don't think the extra complexity is worth it.
I concur, but I'll open a follow-up issue for this and we can change in v0.2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth noting we do use the executeAbility from the @wordpress/abilities package that I don't think exists in 6.9 and is only in the plugin for now (unless I'm mistaken on that). So if we don't want to bundle things, we'll need to account for that (fairly easy to replace that with an apiFetch call)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're talking about the front-end executeAbility method, @dkotter? We may need to use the Gutenberg package, then, because what's in core doesn't have any front-end counterparts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which case we'd need to set Gutenberg as a plugin dependency, which while I'm in favor of Gutenberg being used I don't know that I want AIE to require a plugin dependency. Unless what you're saying is that we'd leverage an npm package from Gutenberg instead of from WP core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. When the Generate button is clicked to generate titles, we end up using executeAbility to generate titles. I originally had that use apiFetch but thought it would be nice to show how you can call an Ability via JS. But if we want to remove the bundling, I can modify that back easy enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like something we should take care of in a subsequent release.
Co-Authored-By: Darin Kotter <darin.kotter@gmail.com>
What?
Closes #104
This pull request updates documentation and metadata to reflect the public release of the AI Experiments plugin and aligns project milestones with WordPress core release dates. The most important changes are grouped below by theme.
Release documentation and changelog updates:
CHANGELOG.mdandreadme.txtto provide a detailed description of the initial public release (0.1.0), including the release date and a summary of key features such as the experiment registry, loader system, title generation experiment, admin settings, WP AI Client SDK integration, and utilities ability. [1] [2]ai.phpto require WordPress 6.9, reflecting compatibility with the latest release.Roadmap and milestone alignment:
ROADMAP.mdto match WordPress 6.9 and 7.0 release cycles, marking completed tasks for milestone 0.1.0 and updating future milestone dates. [1] [2] [3]Contributor recognition:
CREDITS.mdto add and reorder contributor names, ensuring proper recognition for recent contributors.Repository housekeeping:
/CODE_OF_CONDUCT.mdfrom.gitattributesexport-ignore list, allowing it to be included in exported archives.Why?
Prepares for tagging a 0.1.0 release and submitting to WPORG for review.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Test using WordPress Playground
The changes in this pull request can be previewed and tested using this WordPress Playground instance:
Click here to test this pull request.