Skip to content
This repository was archived by the owner on Apr 25, 2024. It is now read-only.

Conversation

@ayanchoudhary
Copy link
Contributor

Fixes

Fixes #1052 by @zackkrida

Description

Introduces trap focus in AppModal and SafeBrowsingModal

Technical details

Uses focus-trap-vue

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@ayanchoudhary ayanchoudhary requested review from a team, akmadian and zackkrida and removed request for a team August 17, 2020 17:31
Copy link
Contributor

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@zackkrida zackkrida merged commit 0d7b592 into develop Aug 17, 2020
@zackkrida zackkrida deleted the trap-focus branch August 17, 2020 17:34
@dhruvkb dhruvkb added the 🕹 aspect: interface Concerns end-users' experience with the software label Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accessibility (a11y) 🕹 aspect: interface Concerns end-users' experience with the software

Development

Successfully merging this pull request may close these issues.

Modal Accessibility Issues

4 participants