Skip to content

Commit 5e50daa

Browse files
sgrifrafaelfranca
authored andcommitted
Revert "Merge pull request rails#27098 from sina-s/fix-unexpected-session-sharing"
This reverts commit cbf2e7a. While this bug is a legitimate bug, this method has been broken in this exact way for quite some time. Any code that is using this method is almost certainly doing it wrong, as it's pretty much impossible to use correctly. That code will all be broken by this change. While this is a good bug fix, and should happen for 5.1, and this method is only used for tests, we should not break all of the code using it in a point release.
1 parent 868d859 commit 5e50daa

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

actionpack/lib/action_dispatch/testing/integration.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,6 @@ def remove! # :nodoc:
453453
# simultaneously.
454454
def open_session
455455
dup.tap do |session|
456-
session.reset!
457456
yield session if block_given?
458457
end
459458
end

actionpack/test/controller/integration_test.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -583,14 +583,6 @@ def test_request_with_bad_format
583583
end
584584
end
585585

586-
test "creation of multiple integration sessions" do
587-
integration_session # initialize first session
588-
a = open_session
589-
b = open_session
590-
591-
refute_same(a.integration_session, b.integration_session)
592-
end
593-
594586
def test_get_with_query_string
595587
with_test_route_set do
596588
get '/get_with_params?foo=bar'

railties/CHANGELOG.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
## Rails 5.0.1.rc1 (December 01, 2016) ##
22

3-
* Reset a new session directly after its creation in ActionDispatch::IntegrationTest#open_session
4-
5-
Fixes Issue #22742
6-
7-
*Tawan Sierek*
8-
93
* Add `:skip_sprockets` to `Rails::PluginBuilder::PASSTHROUGH_OPTIONS`
104

115
*Tsukuru Tanimichi*

0 commit comments

Comments
 (0)