Skip to content

Conversation

@bearomorphism
Copy link
Contributor

Description

Closes #1628.

Checklist

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.68%. Comparing base (120d514) to head (553819d).
⚠️ Report is 852 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
+ Coverage   97.33%   98.68%   +1.34%     
==========================================
  Files          42       60      +18     
  Lines        2104     2656     +552     
==========================================
+ Hits         2048     2621     +573     
+ Misses         56       35      -21     
Flag Coverage Δ
unittests 98.68% <ø> (+1.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -0,0 +1,26 @@
name: non-core improvement proposal
description: Suggest an idea for this project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a feture 🤔

@bearomorphism bearomorphism marked this pull request as draft November 23, 2025 11:30
@Lee-W
Copy link
Member

Lee-W commented Nov 30, 2025

I feel like we don't have anything to add for this one. I'll close it for now. But feel free to re-open it if I'm mistaken. Thanks!

@Lee-W Lee-W closed this Nov 30, 2025
@bearomorphism
Copy link
Contributor Author

I am a little confused ... then why don't we close #1628 if you think the current status of issue form types is good?

@Lee-W Lee-W reopened this Nov 30, 2025
@Lee-W
Copy link
Member

Lee-W commented Nov 30, 2025

after a second thought, I think the non-core can be improved. Question one is not needed as we have GitHub discussion.

@Lee-W
Copy link
Member

Lee-W commented Nov 30, 2025

Non feature improvement maybe?

@bearomorphism
Copy link
Contributor Author

Will fix later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add issue forms of performance improvement, test, refactoring, etc.

2 participants