Add "Collections" section to the extension #249
Conversation
Instead of using the window object to store the global variables, an `appObject` is linked with window object and stores all the global variables of the application. This will avoid any conflict with original window object variables.
|
@aldenstpage The core functionality of the feature has been implemented. Please see the GIF below. I will spend the next couple of days finding and fixing edge cases and implicit bugs that might still be there.
|
…arching for any other collection
|
Fantastic! As for the source images, we hardcode those on the front end, but over time it has become increasingly apparent that the logos ought to be exposed through the API, probably through the |
|
@aldenstpage Nice! With respect to the extension, it will help not increase the build size that is pushed to the extension stores. |
|
@aldenstpage if it makes sense for the extension, I think it would be fine to have @makkoncept do the work to add the logos to the endpoint as part of this project (if you both feel comfortable with it). |
|
I would love to do it. It will take some time though as I am not familiar with the repository and will probably need help if I run into issues in things like setting up the environment, understanding the file structure, etc. Waiting for confirmation from @aldenstpage. |
|
Great, I've made a ticket for this over here. It doesn't seem to be possible to assign it to you, you might need to comment on the ticket first. You can feel free to ask me any questions over Slack or we can move our weekly checkin meeting earlier. I think it would be good for us to discuss whether this will impact the project timeline before we commit you to it. |
|
Yes, there can be some problems as the initial objectives of the timeline are very packed up. Like this first feature took more than 2 weeks and according to the timeline, it should have been completed in 1. So, I think that I should stick to the proposal timeline and concentrate on this project. Is it okay @aldenstpage, @kgodey ? |
These includes chevron-up, search, filter, cross, facebook, twitter and pinterest. Font-awesome is used for the icons which are still not supported by the vocabulary.
|
@aldenstpage a gentle ping... Also, can I merge this? because the next feature builds on a lot of things that are done in this PR. |
|
Hey Mayank, I've reached out to you in a different channel regarding the source endpoint changes. I didn't realize this was ready for review because it still has the WIP tag (although I see it's not a draft anymore now). In the future, please add me as a reviewer once the issue is ready for review, otherwise it's easy for this to get buried in my inbox. |
|
My bad. I didn't notice the |
Motivation
Adding a "Collections” section to the extension would make users appreciate the sources available for them to choose from. They can explore what the sources have to offer and therefore would know what sources they should filter down if they want better results for their queries.
Description
The goal is to add a separate section with the display of the different sources and the ability to "search by collection".
Since CC-Vocabulary will be used for this section, the redesigning of major sections and components of the extension is inevitable for this goal. The extension currently uses a very outdated version of Vocabulary and almost everything will be updated with the new version. The adoption of CC-Vocabulary will be gradual and we need not focus on the details as the main goal is very different for this PR. For starters, I will be focusing on the Options page.
Checklist:
Update index.md).masterbranch of the repository.visible errors.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.