Skip to content

Scroll to top button not getting themed #144224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2022
Merged

Scroll to top button not getting themed #144224

merged 2 commits into from
Mar 3, 2022

Conversation

@kkakroo
Copy link
Contributor

@kkakroo kkakroo commented Mar 2, 2022

This PR fixes #142916

Issue

Scroll to top button was not getting themed

Fix

Updated scroll to top button color to --vscode-button-background and hover color to --vscode-button-hoverBackground.

Test

  • Install a color theme from VSIX.
  • Go to the extension page to check if scroll to top button is displayed as per current theme.

@mjbvz mjbvz merged commit 2cd2f53 into microsoft:main Mar 3, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 3, 2022

Thanks!

@mjbvz mjbvz added this to the March 2022 milestone Mar 3, 2022
@kkakroo kkakroo deleted the scroll-to-top branch March 3, 2022 08:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mjbvz mjbvz

Labels

None yet

Projects

None yet

Milestone

March 2022

Development

Successfully merging this pull request may close these issues.

Add Scroll to Top Color Change

2 participants

@kkakroo @mjbvz