Fix infinite recursion in getDirectoryHandle
#145972
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While opening the root dir (or disk root on windows), launch debug, `getDirectoryHandle` will try to find its parent dir. However `dirname(root)` returns root itself. This caused UI freezed on web target. Add equal detection to fix this bug.
Contributor
Author
|
Bug reproduce:
|
Member
|
Thanks! Maybe file an issue to get this verified. |
gabritto
pushed a commit
to gabritto/vscode
that referenced
this pull request
Mar 25, 2022
While opening the root dir (or disk root on windows), launch debug, `getDirectoryHandle` will try to find its parent dir. However `dirname(root)` returns root itself. This caused UI freezed on web target. Add equal detection to fix this bug.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While opening the root dir (or disk root on windows), launch debug,
getDirectoryHandlewill try to find its parent dir. Howeverdirname(root)returns root itself. This caused UI freezed on web target.Add equal detection to fix this bug.