Skip to content

[Editor] Fix the accessibility of the dropdown in the color picker #20022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

[Editor] Fix the accessibility of the dropdown in the color picker #20022

merged 1 commit into from
Jun 22, 2025

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Jun 19, 2025

No description provided.

@calixteman
Copy link
Contributor Author

calixteman commented Jun 19, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/660f2c6c6ef5a97/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fe849730c650599/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/660f2c6c6ef5a97/output.txt

Total script time: 17.24 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fe849730c650599/output.txt

Total script time: 32.47 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

calixteman commented Jun 19, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/435907c4a9019bd/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8042262915dcfe5/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/435907c4a9019bd/output.txt

Total script time: 15.68 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8042262915dcfe5/output.txt

Total script time: 31.10 mins

  • Integration Tests: FAILED

@calixteman calixteman marked this pull request as draft June 19, 2025 18:01
@calixteman
Copy link
Contributor Author

calixteman commented Jun 19, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/ca7f160d519470a/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f2a55cd181aa3d2/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/ca7f160d519470a/output.txt

Total script time: 14.54 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 19, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/f2a55cd181aa3d2/output.txt

Total script time: 28.97 mins

  • Integration Tests: FAILED

@calixteman calixteman marked this pull request as ready for review June 19, 2025 19:16
@calixteman calixteman requested a review from timvandermeij June 19, 2025 19:16
timvandermeij
timvandermeij reviewed Jun 19, 2025
View reviewed changes
@timvandermeij
Copy link
Contributor

timvandermeij commented Jun 22, 2025

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 22, 2025

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/557dc62cd72e186/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jun 22, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/557dc62cd72e186/output.txt

Total script time: 0.93 mins

Published

@timvandermeij timvandermeij merged commit 8fe9db0 into mozilla:master Jun 22, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

timvandermeij commented Jun 22, 2025

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

accessibility editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @moz-tools-bot @timvandermeij