Skip to content

Build static linux binaries, including arm64 #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2024
Merged

Build static linux binaries, including arm64 #976

merged 1 commit into from
May 2, 2024

Conversation

@cknitt
Copy link
Member

@cknitt cknitt commented May 1, 2024 •
edited
Loading

  • Build static binaries for Linux which fixes glibc compatibility issues. Uses same Docker container as in the rescript-compiler repo.
  • Build Linux ARM binaries.

@cknitt cknitt force-pushed the static-linux-bins branch 6 times, most recently from 7396be3 to d0f6d7e Compare May 1, 2024 18:49
@cknitt cknitt changed the title WIP: Build static linux binaries WIP: Build static linux binaries, including arm64 May 1, 2024
@cknitt cknitt force-pushed the static-linux-bins branch 2 times, most recently from f8ef3d6 to 37a4909 Compare May 2, 2024 05:47
@cknitt cknitt force-pushed the static-linux-bins branch from 37a4909 to 484ec8b Compare May 2, 2024 06:58
@cknitt cknitt changed the title WIP: Build static linux binaries, including arm64 Build static linux binaries, including arm64 May 2, 2024
@cknitt cknitt marked this pull request as ready for review May 2, 2024 07:22
@cknitt cknitt requested a review from zth May 2, 2024 07:22
zth
zth approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely fantastic! Do we need to update any logic around selecting what binary to use...?

@cknitt
Copy link
Member Author

cknitt commented May 2, 2024

The existing logic should be fine:

rescript-vscode/client/src/utils.ts

Line 6 in 3b5824b

process.arch === "arm64" ? process.platform + process.arch : process.platform;

But I haven't really tested it on Linux ARM64 yet. Could you try it?

@zth zth merged commit 5e44e94 into rescript-lang:master May 2, 2024
@cknitt cknitt deleted the static-linux-bins branch May 2, 2024 07:58
This was referenced May 2, 2024
Closed
Closed
jfrolich pushed a commit to jfrolich/rescript-vscode that referenced this pull request Sep 3, 2024
@cknitt @jfrolich
Build static linux binaries (rescript-lang#976)
6e8e9c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zth zth zth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cknitt @zth