fix: change audit descriptions to indicate unsuccessful attempts

[spikecurtis]

fixes #11607

[spikecurtis]

• fix: change audit descriptions to indicate unsuccessful attempts #13897 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite

[aslilac]

I wrote a whole thing about how I'm not crazy about ignoring all of the errors in here, but then I went to look up WriteString to see what errors it could return (I assumed allocation errors) only to see that the docs guarantee that it will only ever return nil. I find this frustrating, because our linting that requires the _, _ = makes it look like you're tossing tons of errors, but the docs explicitly say that you're not if you look them up.

maybe we could leave a comment that it'll never actually return an error despite the return type, to avoid confusion in the future. not a huge deal, I just wanted to flag the emotional journey this just sent me on. 😅

[spikecurtis]

I appreciate the detailed review that you took the time to check WriteString docs. Sorry for winding you up about error checking!

[spikecurtis]

Merge activity

• Jul 16, 2:47 PM EDT: @spikecurtis merged this pull request with Graphite.