Refactor Replace hardcoded schema prefix length #2664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The reason for this change was that when I first looked at the code, it took me a while to understand why the number 21 was used. By relying on the constant value, any future changes to the value can be handled without manually finding and updating the code. Additionally, it makes it easier to understand which length of value is being referenced. 💪🏻😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI 🙋🏻♀️
The code was previously hardcoding the length of the string [
#/components/schemas/] (21) directly in the code. It has now been modified to use the length of the constant value declared in the [Components] class of [ io.swagger.v3.oas.models ].Thank you 🙇🏻♀️