matplotlib-devel Mailing List for matplotlib (Page 2)

Benjamin Root <ben...@ou...> writes:

> I am having difficulty completing a pull request that I opened.  When I try
> to merge the changes to upstream, they get rejected.  I can merge it back to
> my own master, and can even push it up to my github repo's master, but not
> matplotlib's master.

If you're following the merge instructions at
<http://help.github.com/pull-requests/> and getting the merge rejected,
that's likely because your master branch is not up to date. The
instructions start with "git checkout master", but that assumes your
master is the same as matplotlib's master. If that is not the case, you
should first pull from matplotlib into your master - something like

git remote add upstream gi...@gi...:matplotlib/matplotlib.git
git checkout master
git pull --ff-only upstream master

The "remote add" is necessary only once, and it gives the name
"upstream" to the matplotlib central repository (and you have probably
already done it already if you're trying to push into the repository).
Then you checkout your master branch and pull into it from upstream. The
--ff-only flag makes sure that you get an error if you have accidentally
left something on your master that is not in upstream, possibly from
your earlier merge attempts. If you do get that error, the way to clear
it is

git reset --hard upstream/master

but beware that it discards any local changes (so always commit your own
changes on feature branches, not master). (If your changes are
something that you want to save, put them on a new branch first with
"git checkout -b important-local-changes; git commit -a", and then
checkout master again and reset it to upstream/master.)

Then, once your master is up to date, you can merge the pull request and
push to upstream.

> I have tried rebasing my
> branches, but that doesn't seem to solve the problem.

Rebasing branches that you have already pushed somewhere is to be
avoided - if you rebase your feature branch, I don't think e.g. github
will know that the pull request got merged.

> I am thoroughly confused.  Anybody has ideas?  Should I dump my repos and
> start fresh?

No, absolutely not. This is likely just a matter of merging into an
up-to-date master branch.

-- 
Jouni K. Seppänen
http://www.iki.fi/jks

Hi,

i have a question about my personal developement workflow. I wanted to
fix a bug in matplotlib, therefore i checked out the repository.

Then i have to "install" matplotlib (with setupy.py build, setup.py
install). But every time i chenged something, i have to reinstall mpl to
test my changes.

I could make my changes directly in site-packages/matplotlib, but then
it's not version-controlled and the changes must be transferred back.

This workflow seems to be suboptimal, do i miss something?

Thanks,
Maximilian

On 02/25/2011 04:54 PM, Benjamin Root wrote:
>
>
> On Fri, Feb 25, 2011 at 8:01 PM, John Hunter <jd...@gm...
> <mailto:jd...@gm...>> wrote:
>
>
>
>
>
>     On Feb 25, 2011, at 7:00 PM, Christoph Gohlke <cg...@uc...
>     <mailto:cg...@uc...>> wrote:
>
>      > Are PIL and PyGTK holding back matplotlib for Python 3
>
>     Not at all. Both are optional dependencies. Mpl's hard external
>     dependencies are python, zlib, libpng, freetype and numpy.  With
>     those you get the agg, pdf, ps and svg backends.   Various GUI
>     tooolkits are optional, as is PIL, which provides some image reading
>     capabilities and image comparisons for the unit tests.
>
>
> While the GUI toolkits are optional, practically speaking, they are a
> requirement for many (if not most) users.
>
> The damn-ing part about the backends is that many users use only one of
> the GUI backends, and if that one is broken for them, they believe that
> matplotlib is completely broken.  (Evidence: the user who complained
> that matplotlib was not designed correctly when it turned out that the
> macosx backend didn't support (non-?)interactive mode).
>
> PyGTK not being updated for py3k is a heart-breaker for me.  I don't
> want to even imagine what sort of pain in the butt it is going to be to
> program using PyGObject introspection (yeah, that sounds like fun...).

It's not clear to me how bad it will be to handle this in the mpl 
backend.  This page 
(http://live.gnome.org/PyGObject/IntrospectionPorting) suggests it might 
be quite easy, and might not require extensive code change.  I think the 
idea is not so much that the bindings offer a different API but that 
their implementation is different, they are imported differently, and 
the constants are different.  Unfortunately, the python-gobject package 
on Ubuntu 10.10 seems to be broken; the example that comes with it won't 
run.

In any case it appears that with the exception of Tkinter, it may take a 
long time before interactive mpl backends can be used with py3k.

Eric

>
> Ben Root
>

On Fri, Feb 25, 2011 at 10:36 PM, Christoph Gohlke <cg...@uc...> wrote:
> How up to date is matplotlib-py3 with respect to the master branch?

It is currently 5 commits behind matplotlib/master.

On 2/25/2011 6:31 PM, Darren Dale wrote:
> On Fri, Feb 25, 2011 at 9:01 PM, John Hunter<jd...@gm...>  wrote:
>> On Feb 25, 2011, at 7:00 PM, Christoph Gohlke<cg...@uc...>  wrote:
>>
>>> Are PIL and PyGTK holding back matplotlib for Python 3
>>
>> Not at all. Both are optional dependencies. Mpl's hard external dependencies are python, zlib, libpng, freetype and numpy.  With those you get the agg, pdf, ps and svg backends.   Various GUI tooolkits are optional, as is PIL, which provides some image reading capabilities and image comparisons for the unit tests.
>
> Those interested in py3 support should see
> github.com/matplotlib/matplotlib-py3 and
> https://github.com/matplotlib/matplotlib-py3/wiki . Mike D. has
> already made a good start.
>
>

Looks good. I checked out the code from git and gave it a try on 
win-amd64-py3.1. After upgrading CXX to the latest version from svn and 
making some minor modifications to the mpl code (attached), I was able 
to run many examples and also my own scripts without problem (using the 
TkAgg backend). There are more things to fix but it seems that 
matplotlib could soon be usable on Python 3.1. CXX does not yet support 
PyCapsule, which is required for Python 3.2.

How up to date is matplotlib-py3 with respect to the master branch?

Christoph

On Fri, 25 Feb 2011, Darren Dale wrote:

> Here is a pull request proposing some changes to make.osx:
> https://github.com/matplotlib/matplotlib/pull/17 . I have never used
> make.osx myself. Could someone familiar with its use please have a
> look and decide whether the changes should be accepted?
>
> Thanks,
> Darren
>

Hi,

I'm not a matplotlib developer, but a user. I can certainly confirm that 
the libpng link needs to be changed. I discovered that about a month ago. 
That line in my modified version make.osx reads:

         ${PYTHON} -c 'import urllib; 
urllib.urlretrieve("http://sourceforge.net/projects/libpng/files/libpng12/older-releases/${PNGVERSION}/libpng-${PNGVERSION}.tar.gz/download", 
"libpng-${PNGVERSION}.tar.gz")' &&\


You might want to also fix the typo in:

ARCH_FLAGS="-arch i386-arch x86_64"

and then uncoment the lines that used ARCH_FLAGS, but were presumably 
commented out because of the typo and lines with "-arch i386 -arch x86_64"
added.

Cheers,

Jim

On Fri, Feb 25, 2011 at 8:01 PM, John Hunter <jd...@gm...> wrote:

>
>
>
>
> On Feb 25, 2011, at 7:00 PM, Christoph Gohlke <cg...@uc...> wrote:
>
> > Are PIL and PyGTK holding back matplotlib for Python 3
>
> Not at all. Both are optional dependencies. Mpl's hard external
> dependencies are python, zlib, libpng, freetype and numpy.  With those you
> get the agg, pdf, ps and svg backends.   Various GUI tooolkits are optional,
> as is PIL, which provides some image reading capabilities and image
> comparisons for the unit tests.
>

While the GUI toolkits are optional, practically speaking, they are a
requirement for many (if not most) users.

The damn-ing part about the backends is that many users use only one of the
GUI backends, and if that one is broken for them, they believe that
matplotlib is completely broken.  (Evidence: the user who complained that
matplotlib was not designed correctly when it turned out that the macosx
backend didn't support (non-?)interactive mode).

PyGTK not being updated for py3k is a heart-breaker for me.  I don't want to
even imagine what sort of pain in the butt it is going to be to program
using PyGObject introspection (yeah, that sounds like fun...).

Ben Root

On Fri, Feb 25, 2011 at 9:01 PM, John Hunter <jd...@gm...> wrote:
> On Feb 25, 2011, at 7:00 PM, Christoph Gohlke <cg...@uc...> wrote:
>
>> Are PIL and PyGTK holding back matplotlib for Python 3
>
> Not at all. Both are optional dependencies. Mpl's hard external dependencies are python, zlib, libpng, freetype and numpy.  With those you get the agg, pdf, ps and svg backends.   Various GUI tooolkits are optional, as is PIL, which provides some image reading capabilities and image comparisons for the unit tests.

Those interested in py3 support should see
github.com/matplotlib/matplotlib-py3 and
https://github.com/matplotlib/matplotlib-py3/wiki . Mike D. has
already made a good start.

On Feb 25, 2011, at 7:00 PM, Christoph Gohlke <cg...@uc...> wrote:

> Are PIL and PyGTK holding back matplotlib for Python 3

Not at all. Both are optional dependencies. Mpl's hard external dependencies are python, zlib, libpng, freetype and numpy.  With those you get the agg, pdf, ps and svg backends.   Various GUI tooolkits are optional, as is PIL, which provides some image reading capabilities and image comparisons for the unit tests. 

On 2/25/2011 4:03 PM, Benjamin Root wrote:
>
>
> On Fri, Feb 25, 2011 at 5:11 PM, Paul Ivanov <piv...@gm...
> <mailto:piv...@gm...>> wrote:
>
>     Fernando Garcia Bermudez, on 2011-02-03 09:14,  wrote:
>     >  On Thu, Feb 3, 2011 at 06:05, Michael Droettboom <md...@st...
>     <mailto:md...@st...>> wrote:
>     >  > On 02/03/2011 07:48 AM, Darren Dale wrote:
>     >  >> On Thu, Feb 3, 2011 at 12:12 AM, Fernando Garcia Bermudez
>     >  >> <mo...@gm... <mailto:mo...@gm...>>  wrote:
>     >  >>
>     >  >>> Before continuing the debug process, though, I wanted to check
>     with
>     >  >>> someone knowledgeable of this branch regarding its current
>     status. Is
>     >  >>> it possible to compile matplotlib on python3?
>     >  >>>
>     >  >> Mike D. did some initial work for py3 support a while back. I don't
>     >  >> know what platform he was working on, but he was able to produce a
>     >  >> simple plot, maybe running the simple_plot demo.
>     >  >>
>     >  > I was working on Linux (RHEL5), and never got past that platform.
>     >
>     >  I'll stay on the lookout for the github py3k branch and will do as
>     >  suggested. Thanks for the update.
>     >
>
>     By the way, there was a recent poll on python.org
>     <http://python.org> for packages
>     where users desire Python 3 support.
>
>     Here are the top 10:
>
>     Votes | Package
>     ------+--------
>       837  | Django
>       454  | wxPython
>       406  | scipy
>       364  | matplotlib
>       327  | PIL
>       266  | py2exe
>       185  | Twisted
>       179  | PyGTK
>       135  | Pygame
>       94  | web2py
>
>     http://python.org/3kpoll
>
>     best,
>     --
>     Paul Ivanov
>     314 address only used for lists,  off-list direct email at:
>     http://pirsquared.org | GPG/PGP key id: 0x0F3E28F7
>
>
>
> Which just goes to show that some people don't understand
> dependencies... (PIL and PyGTK are needed by matplotllib to be fully
> py3k compatible).  Hopefully this will light a fire for them as well.
>
> Ben Root
>


Are PIL and PyGTK holding back matplotlib for Python 3?

I have a private port of PIL 1.1.7 for Python 3 that is passing all 
tests on Windows <http://www.lfd.uci.edu/~gohlke/pythonlibs/#pil> and 
works well with a couple of other third party libraries (e.g. scipy, 
biopython). Official Python 3 support is planned for PIL 1.2 
<http://mail.python.org/pipermail/image-sig/2011-January/006650.html>.

As for PyGTK, there will likely never be an official version for Python 
3: "PyGtk 2.24 will be the last release in the PyGtk series. ... New 
users wising to develop Python applications using GTK are recommended to 
use the GObject-Introspection features available in PyGObject." 
<http://mail.gnome.org/archives/gnome-announce-list/2011-February/msg00046.html>.

It seems that wxPython, in its current form, will also not be available 
for Python 3. Python 3 support is planned for the "Next Generation" 
<http://wiki.wxpython.org/TentativeRoadmap>. There is a private port of 
wxPython 2.9.x for Python 3 
<http://groups.google.com/group/wxPython-dev/browse_thread/thread/49701177b0a72c6f>. 
I have never gotten it to run reliable.

Are there plans for matplotlib to drop Python 2.4 and 2.5? This would 
make porting to Python 3 much easier.


Christoph

Benjamin Root, on 2011-02-25 18:03,  wrote:
> On Fri, Feb 25, 2011 at 5:11 PM, Paul Ivanov <piv...@gm...> wrote:
> > By the way, there was a recent poll on python.org for packages
> > where users desire Python 3 support.
> >
> > Here are the top 10:
> >
> > Votes | Package
> > ------+--------
> >  837  | Django
> >  454  | wxPython
> >  406  | scipy
> >  364  | matplotlib
> >  327  | PIL
> >  266  | py2exe
> >  185  | Twisted
> >  179  | PyGTK
> >  135  | Pygame
> >  94  | web2py
> >
> > http://python.org/3kpoll
> 
> Which just goes to show that some people don't understand dependencies...
> (PIL and PyGTK are needed by matplotllib to be fully py3k compatible).
> Hopefully this will light a fire for them as well.

Well, this was a user poll - users shouldn't have to know or 
express all of the dependencies for a given package that they use
- that's for us package developers to figure out. 

To quote from the poll conclusions:

  What does this poll mean?
  
  Off-hand, nothing: nominating a package will not mean that its
  authors now start porting it to Python 3.
  
  However, we still hope that this still has some effect on the
  Python community:
  
    * Volunteers trying to help now see where help is most wanted
    * Package authors now see that there really is (or is not)
      demand for getting their package ported.

It's that last point that I was trying to highlight for us, as
matplotlib was the fourth most nominated package for py3k
support.

best,
-- 
Paul Ivanov
314 address only used for lists,  off-list direct email at:
http://pirsquared.org | GPG/PGP key id: 0x0F3E28F7 

On Fri, Feb 25, 2011 at 5:11 PM, Paul Ivanov <piv...@gm...> wrote:

> Fernando Garcia Bermudez, on 2011-02-03 09:14,  wrote:
> > On Thu, Feb 3, 2011 at 06:05, Michael Droettboom <md...@st...>
> wrote:
> > > On 02/03/2011 07:48 AM, Darren Dale wrote:
> > >> On Thu, Feb 3, 2011 at 12:12 AM, Fernando Garcia Bermudez
> > >> <mo...@gm...>  wrote:
> > >>
> > >>> Before continuing the debug process, though, I wanted to check with
> > >>> someone knowledgeable of this branch regarding its current status. Is
> > >>> it possible to compile matplotlib on python3?
> > >>>
> > >> Mike D. did some initial work for py3 support a while back. I don't
> > >> know what platform he was working on, but he was able to produce a
> > >> simple plot, maybe running the simple_plot demo.
> > >>
> > > I was working on Linux (RHEL5), and never got past that platform.
> >
> > I'll stay on the lookout for the github py3k branch and will do as
> > suggested. Thanks for the update.
> >
>
> By the way, there was a recent poll on python.org for packages
> where users desire Python 3 support.
>
> Here are the top 10:
>
> Votes | Package
> ------+--------
>  837  | Django
>  454  | wxPython
>  406  | scipy
>  364  | matplotlib
>  327  | PIL
>  266  | py2exe
>  185  | Twisted
>  179  | PyGTK
>  135  | Pygame
>  94  | web2py
>
> http://python.org/3kpoll
>
> best,
> --
> Paul Ivanov
> 314 address only used for lists,  off-list direct email at:
> http://pirsquared.org | GPG/PGP key id: 0x0F3E28F7
>


Which just goes to show that some people don't understand dependencies...
(PIL and PyGTK are needed by matplotllib to be fully py3k compatible).
Hopefully this will light a fire for them as well.

Ben Root