can't get python to do simple increment in for-loop

Question

I'm just starting with Python (with a good amount of VBA under my belt) so I'm playing around with some simple syntax.

I've written this simple for-loop but the output seems wrong. I can't get the variable 'c' to increment.

Here is my code:

class Card:
    def county(self):
        for n in range(0,13):
            c = 0
            c = c + 1
            print c
    pick_card = Card()
    print pick_card.county()

and the output is just '1' printed 13 times followed by "None"

What am I doing wrong?

You should move c = 0 outside the loop ;). Also, python supports += like in C. so you could do c += 1 instead of c = c + 1 — mgilson
– mgilson, Commented Aug 2, 2012 at 18:43

Wooble · Accepted Answer · 2012-08-02 18:44:10Z

7

Every time through the loop, you're setting c to 0, then adding 1, making it 1.

Also, your last line is printing the return value from your function, which doesn't return anything (hence the "None")

answered Aug 2, 2012 at 18:44

Wooble

90.6k12 gold badges111 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Maksim Skurydzin · Accepted Answer · 2012-08-02 18:58:15Z

1

You are assigning it 0 first and then increment it by 1. Thus it's always 1. Try using the following:

class Card:
    def county(self):
        c = 0
        for n in range(0,13):
            c += 1
            print c
    pick_card = Card()
    print pick_card.county()

edited Aug 2, 2012 at 18:58

answered Aug 2, 2012 at 18:45

Maksim Skurydzin

10.6k9 gold badges45 silver badges55 bronze badges

3 Comments

DBWeinstein Over a year ago

Thanks. Silly mistake on my part.

mgilson Over a year ago

Uh-oh -- IndentationFault ... (sorry, some reason I thought that was funny because it sounds like SegmentationFault).

mgilson Over a year ago

with the way SO determines code (by indenting) and the importance of indenting python code -- these things are bound to happen on a reasonably short timescale.

Collectives™ on Stack Overflow

can't get python to do simple increment in for-loop

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related