Javascript dynamic Array not working

Question

I am currently designing a function for website owners to track what is most commonly searched/entered on their website. To do this I have got a basic function recording what keys are pressed though I want to push these letters into an array so it is easier to manage but I am encountering a problem, it only pushes the last key entered into the array. I am new to programming so go easy on my code :P

Here is the code with the malfunctioning dynamic array:

$(document).ready(function() {
   $(document).keyup(function(objEvent) {
        (objEvent) ? keyCode = objEvent.keyCode : keyCode = event.keyCode;
        varArray = [];
        varLetter = String.fromCharCode(keyCode);
        console.log(varLetter);
        varArray.push(varLetter);
        });
   });

Thanks in advance

-Alex

You should be declaring your variables with var here!

Pointy
– Pointy

2012-08-26 00:34:51 +00:00
Commented Aug 26, 2012 at 0:34 — Pointy
– Pointy, Commented Aug 26, 2012 at 0:34

Daniel A. White · Accepted Answer · 2012-08-26 00:35:22Z

3

You are resetting the array with every key press on this line...

varArray = [];

answered Aug 26, 2012 at 0:35

Daniel A. White

192k49 gold badges389 silver badges474 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Daniel A. White Over a year ago

@AlexSaunders - you might be able to remove it.

jfriend00 · Accepted Answer · 2012-08-26 00:55:40Z

Declare and initialize your array outside of the event handler so it can accumulate keypresses rather than get reset every time. Your current code is setting the array back to be empty on every keypress with varArray = [];.

You can use something like this where varArray is declared and initialized once as a global variable. I also changed varLetter to be a local variable since it is only used locally and there is no need for it to be global:

var varArray = [];
$(document).ready(function() {
   $(document).keyup(function(objEvent) {
        (objEvent) ? keyCode = objEvent.keyCode : keyCode = event.keyCode;
        var varLetter = String.fromCharCode(keyCode);
        console.log(varLetter);
        varArray.push(varLetter);
    });
});

Collectives™ on Stack Overflow

Javascript dynamic Array not working

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related