Mocking Postgres for unit tests with Sinon.js in Node.js

Question

I am having trouble getting my head round how i can use sinon to mock a call to postgres which is required by the module i am testing, or if it is even possible.

I am not trying to test the postgres module itself, just my object to ensure it is working as expected, and that it is calling what it should be calling in this instance.

I guess the issue is the require setup of node, in that my module requires the postgres module to hit the database, but in here I don't want to run an integration test I just want to make sure my code is working in isolation, and not really care what the database is doing, i will leave that to my integration tests.

I have seen some people setting up their functions to have an optional parameter to send the mock/stub/fake to the function, test for its existence and if it is there use it over the required module, but that seems like a smell to me (i am new at node so maybe this isn't).

I would prefer to mock this out, rather then try and hijack the require if that is possible.

some code (please note this is not the real code as i am running with TDD and the function doesn't do anything really, the function names are real)

TEST SETUP

describe('#execute', function () {
it('should return data rows when executing a select', function(){
 //Not sure what to do here
});
});

SAMPLE FUNCTION

PostgresqlProvider.prototype.execute = function (query, cb) {
var self = this;

if (self.connection === "")
    cb(new Error('Connection can not be empty, set Connection using Init function'));

if (query === null)
    cb(new Error('Invalid Query Object - Query Object is Null'))

if (!query.buildCommand)
    cb(new Error("Invalid Query Object"));

//Valid connection and query
};

It might look a bit funny to wrap around the postgres module like this but there are some design as this app will have several "providers" and i want to expose the same API for them all so i can use them interchangeably.

UPDATE

I decided that my test was too complicated, as i was looking to see if the connect call had been made AND then returning data, which smelt to me, so i stripped it back and put it into two tests:

The Mock Test

it('should call pg.connect when a valid Query object is parsed', function(){
        var mockPg = sinon.mock(pg);
        mockPg.expects('connect').once;            

        Provider.init('ConnectionString');
        Provider.execute(stubQueryWithBuildFunc, null, mockPg);

        mockPg.verify();
    });

This works (i think) as without the postgres connector code it fails, with it passes (Boom :))

Issue now is with the second method, which i am going to use a stub (maybe a spy) which is passing 100% when it should fail, so i will pick that up in the morning.

Update 2

I am not 100% happy with the test, mainly because I am not hijacking the client.query method which is the one that hits the database, but simply my execute method and forcing it down a path, but it allows me to see the result and assert against it to test behaviour, but would be open to any suggested improvements.

I am using a spy to catch the method and return null and a faux object with contains rows, like the method would pass back, this test will change as I add more Query behaviour but it gets me over my hurdle.

    it('should return data rows when a valid Query object is parsed', function(){

        var fauxRows = [
            {'id': 1000, 'name':'Some Company A'},
            {'id': 1001, 'name':'Some Company B'}
        ];

       var stubPg = sinon.stub(Provider, 'execute').callsArgWith(1, null, fauxRows);

       Provider.init('ConnectionString');
       Provider.execute(stubQueryWithBuildFunc, function(err, rows){
           rows.should.have.length(2);
       }, stubPg);

       stubPg.called.should.equal.true;
       stubPg.restore();
    });

it seems there needs to be a valid connection first - that means a running instance of postgres to respond to connections to allow the unit-tests... is that right? — Reinsbrain
– Reinsbrain, Commented Jun 15, 2016 at 20:13
Going to be honest, we changed tract and no longer use postgres so this could be a bit off, but if you get the mocking correct you should not need a running instance, the stubs/spys should act as the connection and you should be able to test your code on that basis. — Modika
– Modika, Commented Jun 17, 2016 at 9:22
I've gotten in touch with brianc who is the lead contributor and he mentioned there are some imminent and big changes to pg coming which will make unit-testing much more easy... I'll detail in an answer for future visitors to this question... — Reinsbrain
– Reinsbrain, Commented Jun 21, 2016 at 15:35

Reinsbrain · Accepted Answer · 2016-06-21 15:38:50Z

2

Use pg-pool: https://www.npmjs.com/package/pg-pool

It's about to be added to pg anyway and purportedly makes (mocking) unit-testing easier... from BrianC ( https://github.com/brianc/node-postgres/issues/1056#issuecomment-227325045 ):

Checkout https://github.com/brianc/node-pg-pool - it's going to be the pool implementation in node-postgres very soon and doesn't rely on singletons which makes mocking much easier. Hopefully that helps!

answered Jun 21, 2016 at 15:38

Reinsbrain

2,6412 gold badges27 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pickels · Accepted Answer · 2012-10-27 19:29:48Z

1

I very explicitly replace my dependencies. It's probably not the best solution but all the other solutions I saw weren't that great either.

inject: function (_mock) {
  if (_mock) { real = _mock; }
}

You add this code to the module under test. In my tests I call the inject method and replace the real object. The reason why I don't 100% like it is because you have to add extra code only for testing.

The other solution is to read the module file as a string and use vm to manually load the file. When I investigated this I found it a little to complex so I went with just using the inject function. It's probably worth investigating this approach though. You can find more information here.

answered Oct 27, 2012 at 19:29

Pickels

34.7k26 gold badges121 silver badges181 bronze badges

1 Comment

Modika Over a year ago

thanks for replying, interesting approach, but i am trying to keep my modules as clean as possible if i can, i have found a work around which i have updated the question with, leads me to another issue with the second test mind.

Collectives™ on Stack Overflow

Mocking Postgres for unit tests with Sinon.js in Node.js

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related