Optimizing Java Code Snippet

Question

I;m trying to shorten code on a program I'm coding and the code I need advice on shortening is this part:

imgRunM[0] = toolkit.createImage(imageURL11);
imgRunM[1] = toolkit.createImage(imageURL12);
imgRunM[2] = toolkit.createImage(imageURL13);
imgRunM[3] = toolkit.createImage(imageURL14);
imgRunM[4] = toolkit.createImage(imageURL15);
imgRunM[5] = toolkit.createImage(imageURL16);

I was thinking it could be written as a loop, just not sure how to write it correctly.

I tried this:

for (int x=1; x<7;x++)
  imgRunM[x-1] = toolkit.createImage(imageURL1+x);

It did not error out but when I ran the program, the image did not appear so I'm not really sure what happened.

If anyone has any suggestions I would appreciate it.

its the url for the image, I'm not really going to be able to explain it past that because my teacher in class just coded it into one of our templates a while back. — Exikle
– Exikle, Commented Dec 6, 2012 at 5:52
@Bhavik Shah imageURL10= cl.getResource((picPath+"choiceGirlBoy.png")); this is just and example of what comes from before this code — Exikle
– Exikle, Commented Dec 6, 2012 at 17:32

The111 · Accepted Answer · 2012-12-06 04:43:56Z

2

I'd suggest making an array of imageURL's also, instead of having a new variable name for each one. Then you could do this:

for (int i = 0; i <= 5; i++) {
    imgRunM[i] = toolkit.createImage(imageURL[i+11]);
}

Not sure why you have the +11 offset, but I kept it intact.

edited Dec 6, 2012 at 4:43

answered Dec 6, 2012 at 4:31

The111

5,8674 gold badges42 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

vishal_aim Over a year ago

just change condition to i <= 5

Exikle Over a year ago

Thanks, this helped A LOT,because quite a bit of my code got reduced as i imported many different images.

Collectives™ on Stack Overflow

Optimizing Java Code Snippet

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related